[MetricsAdvisor] Consider avoid using extra Get in some Create operations

[kinelski]

We usually perform an extra Get call at the end of our Create methods to populate our returned models. In CreateDataFeed this is necessary to populate properties that can't be determined at the client side after creation, in special the metric IDs.

Other Create methods, such as CreateHook, don't really obtain any extra information from these extra Get calls, and they're used exclusively to build the returned models. Consider setting the ID using an internal setter and removing the extra call.

Methods to consider:

• CreateDetectionConfiguration
• CreateAlertConfiguration
• CreateHook
• AddFeedback

Concern: consider whether it may be a good idea or not to set the ID of the model used as input by the user. It may be worth cloning the whole model to have separate references.

[ghost]

Hi @kinelski. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

[kinelski]

We decided to keep the extra Get to avoid cloning the input model and to populate default properties originally set to null, what could impact Update operations if the same model was used.