Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SDKv12 crashes during GetBlockList for blobs with large blocks #18976

Closed
egross91 opened this issue Feb 24, 2021 · 7 comments
Closed

[BUG] SDKv12 crashes during GetBlockList for blobs with large blocks #18976

egross91 opened this issue Feb 24, 2021 · 7 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Milestone

Comments

@egross91
Copy link

Describe the bug
Int32 overflow exception when parsing blobs with large block >2.1GiB after calling GetBlockListAsync(...).

Expected behavior
A BlockList to be returned without an exception.

Actual behavior (include Exception or Stack Trace)
An OverflowException is being thrown:

{
  "ExceptionMessage":"Value was either too large or too small for an Int32.","ExceptionType":"OverflowException","ExceptionStack":"
   at System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info)\r\n
   at Azure.Storage.Blobs.Models.BlobBlock.FromXml(XElement element)\r\n
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()\r\n
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)\r\n
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)\r\n
   at Azure.Storage.Blobs.Models.BlockList.FromXml(XElement element)\r\n
   at Azure.Storage.Blobs.BlobRestClient.BlockBlob.GetBlockListAsync_CreateResponse(ClientDiagnostics clientDiagnostics, Response response)\r\n
   at Azure.Storage.Blobs.BlobRestClient.BlockBlob.<GetBlockListAsync>d__12.MoveNext()\r\n
--- End of stack trace from previous location where exception was thrown ---\r\n
   […]
}

To Reproduce

  1. Create a blob with any block size > Int32.MaxValue.
  2. Call GetBlockListAsync(...) from SDK for that created blob.

Environment:

  • Name and version of the Library package used: Azure.Storage.Blobs 12.7.0
  • Hosting platform or OS and .NET runtime version: Windows 10 .NET Framework 4.7.2
  • IDE and version : Visual Studio 16.5

Alias
ergros

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 24, 2021
@amishra-dev amishra-dev added the Storage Storage Service (Queues, Blobs, Files) label Feb 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 24, 2021
@amishra-dev amishra-dev added the Client This issue points to a problem in the data-plane of the library. label Feb 24, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Feb 24, 2021
@amishra-dev amishra-dev added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 24, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Feb 24, 2021
@amishra-dev
Copy link
Contributor

@jaschrep-msft can you please take a look.

@jsquire jsquire added this to the Backlog milestone Feb 24, 2021
@jaschrep-msft
Copy link
Member

This is a bug with our generated code, which means this fix will be dependent on another fix in our swagger repository.

@jaschrep-msft
Copy link
Member

#19078 solves this issue.

@jaschrep-msft
Copy link
Member

This fix will ship with the next release, currently scheduled to be 12.9.0-beta.2.

@egross91
Copy link
Author

egross91 commented Mar 8, 2021

@jaschrep-msft, do you have a rough ETA for when that release will be GA?

@jaschrep-msft
Copy link
Member

@egross91 @seanmcc-msft

@seanmcc-msft
Copy link
Member

Azure.Storage.Blobs v12.0.0-beta.2 shipped on March 9th, and contains the bugfix for this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

5 participants