Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/update TextAnalyticsModelFactory with all new types introduced in 5.1 #18982

Closed
maririos opened this issue Feb 24, 2021 · 2 comments
Closed

Improve/update TextAnalyticsModelFactory with all new types introduced in 5.1 #18982

maririos opened this issue Feb 24, 2021 · 2 comments
Assignees
@mshaban-msft
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2021] July

Comments

@maririos
Copy link
Member

No description provided.

@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Feb 24, 2021
@maririos maririos added this to the [2021] April milestone Feb 24, 2021
@maririos
Copy link
Member Author

maririos commented Mar 9, 2021

Also, add protected constructors to our LROs so they are easily mockable.
We should add a sample for it too.
Similar to what FR did here #18890

@maririos maririos modified the milestones: [2021] April, [2021] May Apr 1, 2021
@maririos maririos modified the milestones: [2021] May, [2021] June Apr 30, 2021
@maririos maririos added the blocking-release Blocks release label May 17, 2021
@maririos
Copy link
Member Author

@AlexanderSher is working on an getting this done with codegen so hopefully we can use that here :)

@maririos maririos modified the milestones: [2021] June, [2021] July Jun 4, 2021
@mshaban-msft mshaban-msft mentioned this issue Jun 9, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mshaban-msft mshaban-msft

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
2 participants
@maririos @mshaban-msft