Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new xxAction types under TextAnalyticsActions #21174

Closed
maririos opened this issue May 18, 2021 · 1 comment · Fixed by #21197
Closed

Create new xxAction types under TextAnalyticsActions #21174

maririos opened this issue May 18, 2021 · 1 comment · Fixed by #21197
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2021] June

Comments

@maririos
Copy link
Member

In https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/textanalytics/Azure.AI.TextAnalytics/api/Azure.AI.TextAnalytics.netstandard2.0.cs#L687
We shouldn't have collections of xxOptions properties. We should create xxAction types that extend from the xxOptions.

See comment:
image.png

JS kind of does this so look at their names
@maririos maririos added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels May 18, 2021
@maririos maririos added this to the [2021] June milestone May 18, 2021
@maririos
Copy link
Member Author

FYI @mssfang

@maririos maririos self-assigned this May 19, 2021
@mssfang mssfang mentioned this issue May 19, 2021
Closed
10 tasks
@maririos maririos mentioned this issue May 19, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[TA] Add action types maririos/azure-sdk-for-net
1 participant
@maririos