Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate perf/API implications of adding a new SchemaId type #24037

Closed
Tracked by #24035
JoshLove-msft opened this issue Sep 16, 2021 · 3 comments
Closed
Tracked by #24035

Investigate perf/API implications of adding a new SchemaId type #24037

JoshLove-msft opened this issue Sep 16, 2021 · 3 comments
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. pillar-performance The issue is related to performance, one of our core engineering pillars. Schema Registry
Milestone
Backlog

Comments

@JoshLove-msft
Copy link
Member

JoshLove-msft commented Sep 16, 2021 •
edited
Loading

This would allow the schema ID to be stored in bytes rather than converting to string. We can expose a ToString method for debugging, and implement comparison based on the ID.
@JoshLove-msft JoshLove-msft mentioned this issue Sep 16, 2021
Closed
13 tasks
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 16, 2021
@JoshLove-msft JoshLove-msft changed the title Investigate perf/API implications of adding a new SchemaId type to allow the ID to be stored in bytes rather than converting to string. We can expose a ToString method for debugging, and implement comparison based on the ID. Investigate perf/API implications of adding a new SchemaId type Sep 16, 2021
@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Sep 16, 2021
@JoshLove-msft JoshLove-msft self-assigned this Sep 16, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 16, 2021
@JoshLove-msft JoshLove-msft added this to the [2021] October milestone Sep 16, 2021
@JoshLove-msft JoshLove-msft added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Sep 16, 2021
@jsquire jsquire modified the milestones: [2021] October, Backlog Oct 14, 2021
@JoshLove-msft
Copy link
Member Author

I'm not sure how much this helps as the schema Id needs to be passed as a string when looking up a schema by ID.

@JoshLove-msft
Copy link
Member Author

/cc @KrzysztofCwalina

@JoshLove-msft
Copy link
Member Author

Closing as we decided it didn't help with perf.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. pillar-performance The issue is related to performance, one of our core engineering pillars. Schema Registry
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jsquire @JoshLove-msft