Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OperationInternal for CertificateOperation #25627

Closed
heaths opened this issue Dec 2, 2021 · 3 comments
Closed

Use OperationInternal for CertificateOperation #25627

heaths opened this issue Dec 2, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented Dec 2, 2021

I used OperationInternal for pseudo-LROs in Key Vault with PR #25593 (issue #22912) but CertificateOperation is a bit different and may require additional discussions and changes to OperationInternal (or OperationInternal<T>) to support cancelled states. Specifically, the Cancel and Delete methods on CertificateOperation need consideration whether that creates a successful state with no value or a failed state, which would cause subsequent UpdateStatus/Async calls to throw, which would be a behavioral change.

I don't think any of this is necessarily a hard problem to solve, but being shared code want to make sure we consider a robust strategy.

@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Dec 2, 2021
@heaths heaths added this to the Backlog milestone Dec 2, 2021
@heaths heaths self-assigned this Dec 2, 2021
@heaths heaths modified the milestones: Backlog, 2023-01 Oct 24, 2022
@jsquire jsquire modified the milestones: 2023-01, Backlog Jan 19, 2023
@pallavit
Copy link
Contributor

@heaths - Is this still an issue we want to tackle?

@heaths
Copy link
Member Author

heaths commented Sep 14, 2023

Those working on our helpers like Pavel and @AlexanderSher back in the day requested this, but it's clearly not been a priority. Personally, I don't think it's worth it and, if we get serious about auto-generating, would be done automatically anyway. I wonder if Alexander still wants this?

@pallavit
Copy link
Contributor

I will go ahead and close it in that case.

@pallavit pallavit closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Archived in project
Development

No branches or pull requests

3 participants