Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is value of SecretProperties.ExpiresOn based on UTC time? #25837

Closed
Yomodo opened this issue Dec 9, 2021 · 4 comments
Closed

Is value of SecretProperties.ExpiresOn based on UTC time? #25837

Yomodo opened this issue Dec 9, 2021 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Yomodo
Copy link

Yomodo commented Dec 9, 2021

SecretProperties.ExpiresOn, from the documentation it is not clear if the value is based on UTC time,
as is the case with AuthenticationResult.ExpiresOn property.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 9, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Dec 9, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 9, 2021
@jsquire
Copy link
Member

jsquire commented Dec 9, 2021

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@heaths
Copy link
Member

heaths commented Jan 4, 2022

The service properties are, yes, but the property type - a DateTimeOffset - always has an associated time zone offset so whether you convert to local time or UTC time (the latter would be a no-op) it won't matter: you get the right date as originally based on the service time zone offset (UTC). This is why we use DateTimeOffset instead of DateTime, which may or may not have a timezone offset and can lead to ambiguities like this. See https://docs.microsoft.com/dotnet/api/system.datetimeoffset for details.

@heaths heaths added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Hi @Yomodo. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost ghost removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jan 4, 2022
@Yomodo
Copy link
Author

Yomodo commented Jan 5, 2022

@heaths Thank you for the clear explanation.

@Yomodo Yomodo closed this as completed Jan 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

4 participants
@jsquire @heaths @Yomodo and others