Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Set up mapping between spec repo folder and SDK repo folder for SDK automation #37335

Closed
live1206 opened this issue Jun 30, 2023 · 3 comments · Fixed by #38411
Closed
Assignees
Labels
Mgmt This issue is related to a management-plane library.

Comments

@live1206
Copy link
Member

Library name and version

Azure.ResourceManager.Sql

Describe the bug

Right now, in spec repo the folder is sql.
But, in azure-sdk-for-net the folder is sqlmanagement.
This mismatching is causing failures of .NET SDK track 2 automation for swagger PRs of sql.

Expected behavior

The folder names should align.

Actual behavior

Folder names do not align.

Reproduction Steps

Azure/azure-rest-api-specs#24349 (comment)
.NET SDK Track 2 automation is failing.

Environment

No response

@live1206 live1206 added the Mgmt This issue is related to a management-plane library. label Jun 30, 2023
@live1206 live1206 self-assigned this Jun 30, 2023
@jsquire jsquire added the SQL label Jun 30, 2023
@live1206
Copy link
Member Author

live1206 commented Jul 19, 2023

After discussing with @m-nash, we can't guarantee to align the folder structure for all RPs.
There are cases some RPs are sharing the same swagger folder, but they would like to release their SDKs separately, which end up into different SDK folders.

There is a property specifying the SDK structure in TypeSpec, we can have something similar in .NET SDK automation to have the mapping between swagger folder to SDK folder.

@tdoshin
Copy link

tdoshin commented Aug 9, 2023

Can this be closed? @live1206

@live1206 live1206 removed the SQL label Aug 10, 2023
@live1206 live1206 changed the title [BUG] Rename sqlmanagement to sql to align with spec repo [BUG] Set up mapping between spec repo folder and SDK repo folder for SDK automation Aug 10, 2023
@live1206
Copy link
Member Author

@tdoshin Not really, this still needs to be fixed, renamed to repurpose.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants