Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Monitor Distro] Duplicate attribute definition #38994

Closed
m-redding opened this issue Sep 27, 2023 · 0 comments · Fixed by #38995
Closed

[Azure Monitor Distro] Duplicate attribute definition #38994

m-redding opened this issue Sep 27, 2023 · 0 comments · Fixed by #38995
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro

Comments

@m-redding
Copy link
Member

Library name

Azure.Monitor.OpenTelemetry.AspNetCore

Please describe the feature.

The file UnconditionalSuppressMessageAttribute.cs added in #38848 adds an attribute that we provide through Azure.Core in TrimmingAttribute.cs. Having both is causing conflicts and failing the core ci pipeline.

You should be able to remove this file and just add a reference to the TrimmingAttribute.cs file available through Azure.Core shared source. They were both added to solve the same problem so it should be equivalent to use either option.

This is blocking:

@m-redding m-redding added Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro labels Sep 27, 2023
@TimothyMothra TimothyMothra self-assigned this Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants