-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial KeyVaultProxy solution #15123
Conversation
I'm moving this from my person repo where I used it as an example for both the KV service team and on social like Stack Overflow. It builds in and out of the repo correctly. I am considering, though, that maybe the README with the sample front matter should be only in the src directory, since:
Do people agree I should just make the src project itself the published sample and leave the tests here? Should I make sure they run as part of nightlies? |
sdk/keyvault/Microsoft.Azure.KeyVault/tests/Microsoft.Azure.KeyVault.Tests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look deeply at the code but the general structure looks fine. I assume you add the snippets to make sure they stay updated in the MD.
I'm Ok with having the tests here, but I'm not sure we should add them to our nightly test runs. Eventually we should get the sample code running in our smoke tests and given this is kind of a sample library we should either write a sample application or maybe use the tests as a proxy and run as part of those smoke tests. |
I agree keeping the test source is good, but I was referring more to whether only As for getting them running, I'll open a test issue on the backlog. I had considered this, but even getting sample source that builds and runs correctly in our repo and as a standalone downloaded sample is enough of a pain without complicating the source. I brought this up yesterday in our .NET team meeting as well (other people are looking to add samples) and want to with you more about it. |
Ported with permission from @heaths from https://github.com/heaths/KeyVaultProxy. Builds both within and without the Azure/azure-sdk-for-net repo.
d97f9ff
to
5aa354a
Compare
Ported with permission from @heaths from https://github.com/heaths/KeyVaultProxy. Builds both within and without the Azure/azure-sdk-for-net repo.