From b7d597d5c61e5dbfa901d24eb66fbfc1dfadb0b3 Mon Sep 17 00:00:00 2001 From: Pavel Krymets Date: Mon, 19 Oct 2020 14:55:19 -0700 Subject: [PATCH 1/2] Remove the preview language version --- eng/Directory.Build.Data.props | 1 - samples/linecounter/LineCounter.csproj | 1 - .../tests/Microsoft.Azure.EventHubs.Tests.csproj | 1 - 3 files changed, 3 deletions(-) diff --git a/eng/Directory.Build.Data.props b/eng/Directory.Build.Data.props index 4c8aa548c2af7..246a1413b8fb2 100644 --- a/eng/Directory.Build.Data.props +++ b/eng/Directory.Build.Data.props @@ -135,7 +135,6 @@ false false false - preview $(IntermediateOutputPath)$(TargetFramework)\$(MSBuildProjectName).xml diff --git a/samples/linecounter/LineCounter.csproj b/samples/linecounter/LineCounter.csproj index ffea9fdc3e70f..d2b20a732ef03 100644 --- a/samples/linecounter/LineCounter.csproj +++ b/samples/linecounter/LineCounter.csproj @@ -1,7 +1,6 @@  netcoreapp3.0 - preview 67ca5d37-051b-4ab1-b013-c74a2d4edb76 diff --git a/sdk/eventhub/Microsoft.Azure.EventHubs/tests/Microsoft.Azure.EventHubs.Tests.csproj b/sdk/eventhub/Microsoft.Azure.EventHubs/tests/Microsoft.Azure.EventHubs.Tests.csproj index f49164d925e7f..eefc105129980 100755 --- a/sdk/eventhub/Microsoft.Azure.EventHubs/tests/Microsoft.Azure.EventHubs.Tests.csproj +++ b/sdk/eventhub/Microsoft.Azure.EventHubs/tests/Microsoft.Azure.EventHubs.Tests.csproj @@ -3,7 +3,6 @@ true 2.2.0 $(RequiredTargetFrameworks) - preview true From 0d9e73547a6a360fbc9edd03eaef802d973a9d02 Mon Sep 17 00:00:00 2001 From: Pavel Krymets Date: Mon, 19 Oct 2020 15:11:06 -0700 Subject: [PATCH 2/2] Remove new features --- .../tests/SharedTokenCacheCredentialTests.cs | 2 +- .../Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs b/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs index 640cc2d1a9344..530bf2eaa5b82 100644 --- a/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs +++ b/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs @@ -37,7 +37,7 @@ public async Task VerifyAuthenticationRecordOption() var mockMsalClient = new MockMsalPublicClient { Accounts = new List { new MockAccount("nonexpecteduser@mockdomain.com") }, - ExtendedSilentAuthFactory = (_, account, _, _) => + ExtendedSilentAuthFactory = (_, account, __, ___) => { Assert.AreEqual(expectedUsername, account.Username); diff --git a/sdk/storage/Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs b/sdk/storage/Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs index afb2fc7102e83..5faa8e29b3442 100644 --- a/sdk/storage/Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs +++ b/sdk/storage/Azure.Storage.Blobs.ChangeFeed/tests/ShardTests.cs @@ -70,7 +70,7 @@ public async Task GetCursor() It.IsAny(), It.IsAny(), It.IsAny())) - .Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object)); + .Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object)); ShardFactory shardFactory = new ShardFactory( containerClient.Object, @@ -172,7 +172,7 @@ public async Task HasNext_False() It.IsAny(), It.IsAny(), It.IsAny())) - .Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object)); + .Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object)); chunks["chunk5"].Setup(r => r.HasNext()).Returns(false); @@ -271,7 +271,7 @@ public async Task HasNext_ChunksLeft() It.IsAny(), It.IsAny(), It.IsAny())) - .Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object)); + .Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object)); ShardFactory shardFactory = new ShardFactory( containerClient.Object, @@ -366,7 +366,7 @@ public async Task HasNext_CurrentChunkHasNext() It.IsAny(), It.IsAny(), It.IsAny())) - .Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object)); + .Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object)); chunks["chunk5"].Setup(r => r.HasNext()).Returns(true); @@ -482,7 +482,7 @@ public async Task Next() It.IsAny(), It.IsAny(), It.IsAny())) - .Returns((bool _, string path, long _, long _, CancellationToken _) => Task.FromResult(chunks[path].Object)); + .Returns((bool _, string path, long __, long ___, CancellationToken ____) => Task.FromResult(chunks[path].Object)); chunks["chunk2"].SetupSequence(r => r.HasNext()) .Returns(true)