Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Prepare 5.0 data plane SDK for release #4246

Merged
merged 7 commits into from
Apr 19, 2018

Conversation

brjohnstmsft
Copy link
Member

@brjohnstmsft brjohnstmsft commented Apr 18, 2018

Description

This includes all changes necessary to prepare version 5.0 of the Azure Search data plane SDK for release. These changes include:

  • Regenerate SDK code from the Swagger spec for the new GA REST API version, 2017-11-11.
  • Remove preview features that aren't included in the new GA version.
  • Update version numbers and release notes for all packages.
  • Re-record all session records for the new API version.

Related spec PRs:

FYI @shahabhijeet @Yahnoosh @mhko @natinimni @chaosrealm


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can you build the management plan SDK on command line as below
msbuild build.proj /t:Build /p:Scope=SDKs\Search\Management

this will update the meta data in AzSdk.RP.props

@shahabhijeet
Copy link
Member

Actually looks good, got confused with API version from the data plane. Management plane looks good.
Merging it

@shahabhijeet shahabhijeet merged commit f6fc0e4 into Azure:psSdkJson6 Apr 19, 2018
@brjohnstmsft brjohnstmsft deleted the search-5x-ga branch April 19, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants