From 385000be24fd3ee4e0a52a1b8712b51e64768c23 Mon Sep 17 00:00:00 2001 From: Matthew Christopher Date: Fri, 14 Dec 2018 09:50:04 -0800 Subject: [PATCH] Fix batch changelog and test --- .../JobPrepReleaseIntegrationTests.cs | 6 +++--- src/SDKs/Batch/DataPlane/changelog.md | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/SDKs/Batch/DataPlane/Azure.Batch.IntegrationTests/JobPrepReleaseIntegrationTests.cs b/src/SDKs/Batch/DataPlane/Azure.Batch.IntegrationTests/JobPrepReleaseIntegrationTests.cs index b55e8da511c59..bdb5e5befcbbd 100644 --- a/src/SDKs/Batch/DataPlane/Azure.Batch.IntegrationTests/JobPrepReleaseIntegrationTests.cs +++ b/src/SDKs/Batch/DataPlane/Azure.Batch.IntegrationTests/JobPrepReleaseIntegrationTests.cs @@ -324,7 +324,7 @@ public void TestOMJobPrepSchedulingError() JobPreparationTask prep = new JobPreparationTask("cmd /c JobPrep Task"); unboundJob.JobPreparationTask = prep; - ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://127.0.0.1/foo/bar/baf", "bob.txt")}; + ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://not.a.domain.invalid/file", "bob.txt")}; prep.ResourceFiles = badResFiles; @@ -416,8 +416,8 @@ public void TestOMJobReleaseSchedulingError() { JobReleaseTask relTask = new JobReleaseTask("cmd /c echo Job Release Task"); unboundJob.JobReleaseTask = relTask; - - ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://127.0.0.1/foo/bar/baf", "bob.txt")}; + + ResourceFile[] badResFiles = { ResourceFile.FromUrl("https://not.a.domain.invalid/file", "bob.txt")}; relTask.ResourceFiles = badResFiles; diff --git a/src/SDKs/Batch/DataPlane/changelog.md b/src/SDKs/Batch/DataPlane/changelog.md index fe774f1c874de..8df9871d3a742 100644 --- a/src/SDKs/Batch/DataPlane/changelog.md +++ b/src/SDKs/Batch/DataPlane/changelog.md @@ -14,11 +14,13 @@ - `ResourceFile.FromStorageContainerUrl` creates a `ResourceFile` pointing to an Azure Blob Storage container. - `ResourceFile.FromAutoStorageContainer` creates a `ResourceFile` pointing to an Azure Blob Storage container in the Batch registered auto-storage account. - URLs provided to `ResourceFile` via the `ResourceFile.FromUrl` method can now be any HTTP URL. Previously, these had to be an Azure Blob Storage URL. + - The `BlobPrefix` property can be used to filter downloads from a storage container to only those matching the prefix. - **[Breaking]** Removed `OSDisk` property from `VirtualMachineConfiguration`. This property is no longer supported. - Pools which set the `DynamicVNetAssignmentScope` on `NetworkConfiguration` to be `DynamicVNetAssignmentScope.Job` can now dynamically assign a Virtual Network to each node the job's tasks run on. The specific Virtual Network to join the nodes to is specified in the new `JobNetworkConfiguration` property on `CloudJob` and `JobSpecification`. - - **Note**: This feature is in public preview. It is disabled for all Batch accounts except for those + - **Note**: This feature is in public preview. It is disabled for all Batch accounts except for those which have contacted us and requested to + be in the pilot. - The maximum lifetime of a task is now 180 days (previously it was 7). - Added support on Windows pools for creating users with a specific login mode (either `Batch` or `Interactive`) via `WindowsUserConfiguration.LoginMode`. - The default task retention time for all tasks is now 7 days, previously it was infinite.