Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a Service Bus Connection String Parser #14574

Closed
jsquire opened this issue Oct 16, 2020 · 0 comments · Fixed by #14772
Closed

Implement a Service Bus Connection String Parser #14574

jsquire opened this issue Oct 16, 2020 · 0 comments · Fixed by #14772
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@jsquire
Copy link
Member

jsquire commented Oct 16, 2020

Summary

Service Bus allows for authorization using a shared key and shared access signature that is supported using a service-specific shared access key credential. It is common for the shared key or shared access signature to be passed with the service endpoint and entity path as part of a connection string. To align with best practices, we would like to guide library users to down the path of using credentials for authorization within production applications. In order to assist with transforming a connection string for use with credential-based client creation, a parsing utility is desirable.

Scope of Work

  • Design and implementation of a means for parsing a Service Bus connection string into its components. These should include:

    • FullyQualifiedNamespace
    • Endpoint
    • EntityPath
    • SharedAccessSignature
    • SharedAccessKeyName
    • SharedAccessKey

  • The parser should adhere to the current validation rules for connection string correctness. For example:

    • Only one form of authorization should be allowed (shared key or shared access signature)
    • The Endpoint must be present
    • The EntityPath is optional
    • All tokens which are present must have an associated value

  • The host name of the Endpoint should be reflected as the FullyQualifiedNamespace.

  • Unknown tokens in the connection string are rejected or ignored; they are not reflected in the set of parsed tokens.

  • The parsed values should be treated as read-only, if idiomatic to the language.

  • The proposed surface area of the parser, as well as any associated types that change the public API surface should be reviewed with the language architect, and approval obtained. Full board review is not necessary.

Success Criteria

  • The design of a parser detailed by the scope has been completed and approved by the language architect.

  • The parser has been implemented according to the design and is exposed as part of the public API of the library.

  • The tests necessary for its validation have been created or adjusted and pass reliably.

  • The existing test suite continues to produce deterministic results and pass reliably.

References

@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Oct 16, 2020
@KieranBrantnerMagee KieranBrantnerMagee removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 16, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants