Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Update docs/README #16094

Closed
swathipil opened this issue Jan 12, 2021 · 1 comment · Fixed by #16215
Closed

[Event Hubs] Update docs/README #16094

swathipil opened this issue Jan 12, 2021 · 1 comment · Fixed by #16215
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Milestone
[2021] February

Comments

@swathipil
Copy link
Member

  • In the Event Hubs README, under section Create client using the azure-identity library, add the azure-identity installation step: pip install azure-identity

similar to the form recognizer README AAD section
@swathipil swathipil self-assigned this Jan 12, 2021
@yunhaoling
Copy link
Contributor

we also need to mention async transport support (aiohttp) if people want to use azure-identity in async world, could just be a short sentence.

@yunhaoling yunhaoling added Client This issue points to a problem in the data-plane of the library. Docs labels Jan 12, 2021
@swathipil swathipil added this to the [2021] February milestone Jan 13, 2021
@swathipil swathipil mentioned this issue Jan 16, 2021
Merged
@swathipil swathipil linked a pull request Jan 19, 2021 that will close this issue
[Event Hubs] updated README with install steps for azure-identity and aiohttp #16215
Merged
@swathipil swathipil mentioned this issue Jan 20, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs
Projects
None yet
Milestone
[2021] February
2 participants
@yunhaoling @swathipil