Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "raise_for_status" in HttpResponse #16336

Closed
lmazuel opened this issue Jan 26, 2021 · 0 comments · Fixed by #16399
Closed

Add "raise_for_status" in HttpResponse #16336

lmazuel opened this issue Jan 26, 2021 · 0 comments · Fixed by #16399
Assignees
@iscai-msft
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] February

Comments

@lmazuel
Copy link
Member

lmazuel commented Jan 26, 2021 

response.raise_for_status()

Inspiration:
https://github.com/psf/requests/blob/4f6c0187150af09d085c03096504934eb91c7a9e/requests/models.py#L920-L943
https://github.com/aio-libs/aiohttp/blob/742a8b6d09b2623670ddede838c913d2a8a4d89e/aiohttp/client_reqrep.py#L920-L940
https://github.com/encode/httpx/blob/86964054d60da7796c65e501ba021440b14cc36c/httpx/_models.py#L1087-L1108
@lmazuel lmazuel added feature-request This issue requires a new behavior in the product in order be resolved. Azure.Core blocking-release Blocks release labels Jan 26, 2021
@lmazuel lmazuel added this to the [2021] February milestone Jan 26, 2021
@lmazuel lmazuel added the Client This issue points to a problem in the data-plane of the library. label Jan 26, 2021
@iscai-msft iscai-msft mentioned this issue Jan 28, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iscai-msft iscai-msft

Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] February
Development

Successfully merging a pull request may close this issue.

[core] add raise_for_status to HttpResponse iscai-msft/azure-sdk-for-python
2 participants
@lmazuel @iscai-msft