[Communication] - Phone Numbers - Fixed apiview warnings #17172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeauregardb
requested review from
ankitarorabit,
memontic-ms,
turalf and
a team
as code owners
sacheu
reviewed
Mar 9, 2021
...mmunication-phonenumbers/azure/communication/phonenumbers/aio/_phone_numbers_client_async.py
Outdated
Show resolved
Hide resolved
sacheu
reviewed
Mar 9, 2021
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
sacheu
reviewed
Mar 9, 2021
sacheu
reviewed
Mar 9, 2021
| from ._generated._phone_numbers_client import PhoneNumbersClient as PhoneNumbersClientGen | ||
| from ._generated.models import PhoneNumberSearchRequest | ||
| from ._shared.utils import parse_connection_str, get_authentication_policy | ||
| from ._version import SDK_MONIKER | ||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
What is the 'if TYPE_CHECKING' for?
There was a problem hiding this comment.
This is a validation we put for the interpreter to have reference to the types of parameters we declare in our code. It's just type hinting stuff.
There was a problem hiding this comment.
do we need to add this in all other files?
There was a problem hiding this comment.
We already have it on chat and PNM as of now.
jbeauregardb
force-pushed
the
type-hinting
branch
2 times, most recently
from
b6c9e64
to
46d1ce3
Compare
jbeauregardb
force-pushed
the
type-hinting
branch
from
46d1ce3
to
4d42a41
Compare
jbeauregardb
force-pushed
the
type-hinting
branch
from
4d42a41
to
df0facf
Compare
lsundaralingam
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.