Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] checkpointstoretable: add tests + config necessary envvars #20276

Closed
swathipil opened this issue Aug 13, 2021 · 2 comments · Fixed by #20376
Closed

[EventHubs] checkpointstoretable: add tests + config necessary envvars #20276

swathipil opened this issue Aug 13, 2021 · 2 comments · Fixed by #20376
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Milestone
[2021] September

Comments

@swathipil
Copy link
Member

swathipil commented Aug 13, 2021 •
edited
Loading

clean up checkpointstoretable:

  • add environment variables for tests: Tables connection string --> look at test-resources.json in Tables
  • check to see if MatchConditions.IfNotModified should be passed in in _update_ownership (what is the difference b/w passing this and nothing?)
  • other misc things: clean up redundancies
@swathipil swathipil added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Aug 13, 2021
@swathipil swathipil added this to the [2021] September milestone Aug 13, 2021
@swathipil swathipil self-assigned this Aug 13, 2021
@swathipil swathipil added the Messaging Messaging crew label Aug 16, 2021
@swathipil swathipil mentioned this issue Aug 16, 2021
Merged
@swathipil
Copy link
Member Author

swathipil commented Aug 18, 2021 •
edited
Loading

sync up with Chris on timeline so we can release with JS --> sometime before semester ends

@swathipil swathipil mentioned this issue Aug 20, 2021
Merged
@swathipil
Copy link
Member Author

move this outside try:

azure-sdk-for-python/sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

Line 146 in 6821987

ownership_entity = TableCheckpointStore._create_ownership_entity(ownership)

remove IfNotModified + "etag" being passed in:

azure-sdk-for-python/sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

Line 151 in 6821987

match_condition=MatchConditions.IfNotModified,

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Projects
None yet
Milestone
[2021] September
Development

Successfully merging a pull request may close this issue.

[EventHub] update arm template with storage conn str swathipil/azure-sdk-for-python
1 participant
@swathipil