Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLU - March SDK - Resolution casting/polymorphism #23754

Closed
mshaban-msft opened this issue Mar 30, 2022 · 1 comment
Closed

CLU - March SDK - Resolution casting/polymorphism #23754

mshaban-msft opened this issue Mar 30, 2022 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language Cognitive - LUIS

Comments

@mshaban-msft
Copy link
Contributor

  • Package Name: ConversationAnalysisClient (azure.ai.language.conversations)
  • Package Version: 1.0.0b3

Describe the bug
CLU March APIs introduced the concept of resolutions with each entity.
There are many types of resolutions which share the same BaseResolution class that uses resolution_kind property to cast this BaseResolution into one of these other sub-types like: AgeResolution, or DateTimeResolution.
The problem is that even though every subtype defines this resolution_kind property with each's own value, python couldn't type cast this base class into corresponding sub type.

To Reproduce
Steps to reproduce the behavior:

  1. simply run the sample_analyze_conversation_app.py in the samples dir (using your own resource).
  2. debug the code at line 87 to catch any of entity resolutions.

Expected behavior
Resolution should be any of the subtypes (not BaseResolution).
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2022
@azure-sdk azure-sdk added Mgmt This issue is related to a management-plane library. needs-team-triage Workflow: This issue needs the team to triage. Storage Storage Service (Queues, Blobs, Files) labels Mar 30, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2022
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Language and removed Storage Storage Service (Queues, Blobs, Files) Mgmt This issue is related to a management-plane library. needs-team-triage Workflow: This issue needs the team to triage. labels Mar 31, 2022
@kristapratico
Copy link
Member

closing this since we don't have models generated in CLU.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language Cognitive - LUIS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mshaban-msft @kristapratico @azure-sdk