Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] ArchBoard Review Items #24357

Closed
5 tasks done
simorenoh opened this issue May 9, 2022 · 4 comments
Closed
5 tasks done

[Cosmos] ArchBoard Review Items #24357

simorenoh opened this issue May 9, 2022 · 4 comments
Assignees

Comments

@simorenoh
Copy link
Member

simorenoh commented May 9, 2022

Using this issue to keep track of items mentioned during the arch-board review. These are:

Others:

  • open an issue to make refresh_routing_map_provider() and entire CosmosClientConnection object private: [Cosmos] Make CosmosClientConnection object private #24359
  • conversation around the enable_cross_partition_query option and functionality in sync vs. async clients
  • conversation on naming of read_conflict() vs get_conflict() - going with get, changes in the offer PR below
  • look into post_trigger_include method option and see whether it needs to be deprecated in sync client/ included in async one

We're also still missing merging these PRs:

@simorenoh simorenoh self-assigned this May 9, 2022
@simorenoh
Copy link
Member Author

PR for first of the two: #24358

@simorenoh simorenoh changed the title [Cosmos] [Cosmos] ArchBoard Review Items May 9, 2022
@simorenoh
Copy link
Member Author

  • look into post_trigger_include method option and see whether it needs to be deprecated in sync client/ included in async one

For this one, this functionality is something we should support, and as such should remain in the async and sync clients. More on the rest api functionality on this if needed: https://docs.microsoft.com/rest/api/cosmos-db/triggers

@simorenoh
Copy link
Member Author

simorenoh commented May 9, 2022

  • naming of read_conflict() vs get_conflict()

For this one, I also found that all READ calls in the scripts.py file are named as 'get_xxx' even though they make network calls and incur in RU usage - with this in mind, we should ensure we have the same standard all around.

@simorenoh
Copy link
Member Author

4.3.0 Released https://pypi.org/project/azure-cosmos/4.3.0/

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants