Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude_shared_token_cache_credential default value is False in Python version SDK. #29462

Closed
Kit-Law-42 opened this issue Mar 20, 2023 · 4 comments
Assignees
Labels
Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Kit-Law-42
Copy link

  • Package Name: azure.identity
  • Package Version: 1.13
  • Operating System: Windows10
  • Python Version: 3.9.16

Describe the bug
exclude_shared_token_cache_credential default value is False in DefaultAzureCredential() class

To Reproduce
Initiate DefaultAzureCredential class.

Expected behavior
Expecting same behaviour between .NET and Python, default value is True.

**DIscussion threads on .NET SDK in 2020
https://learn.microsoft.com/en-us/dotnet/api/azure.identity.defaultazurecredentialoptions?view=azure-dotnet
Azure/azure-sdk-for-net#17052
Azure/azure-sdk#1970

Screenshots
image

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 20, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 20, 2023
@xiangyan99 xiangyan99 self-assigned this Mar 20, 2023
@xiangyan99 xiangyan99 added Azure.Identity and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 20, 2023
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 20, 2023
@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@xiangyan99
Copy link
Member

@Kit-Law-42 Thanks for pointing out the inconsistencies.

.net deprecated SharedTokenCacheCredential from DefaultAzureCredential because they added VisualStudioCredential to take care of the scenario that users want to use the login information from VS to authenticate.

While for Python, we still rely on SharedTokenCacheCredential for such scenario. And this is the reason we keep it in the DefaultAzureCredential.

Thank you.

@xiangyan99 xiangyan99 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Mar 23, 2023
@ghost
Copy link

ghost commented Mar 23, 2023

Hi @Kit-Law-42. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost ghost removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 23, 2023
@ghost
Copy link

ghost commented Mar 30, 2023

Hi @Kit-Law-42, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Mar 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

2 participants