Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzMon Distro should enable Azure AI Inference instrumentation #37479

Closed
lmolkova opened this issue Sep 19, 2024 · 3 comments · Fixed by #38071
Closed

AzMon Distro should enable Azure AI Inference instrumentation #37479

lmolkova opened this issue Sep 19, 2024 · 3 comments · Fixed by #38071
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

Azure AI Inference instrumentation being added in #36890 uses monkey-patching approach for instrumentation and needs someone to call AIInferenceApiInstrumentor().Instrument().

The approach can change in the future and hopefully can be done inside azure-ai-inference. For now it'd be great for AzMon distro to enable it by default along with other Azure SDKs.

Once #36890 is merged, we'll need to update distro to instrument it.

@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Monitor - Distro Monitor OpenTelemetry Distro labels Sep 19, 2024
@lmolkova
Copy link
Member Author

/cc @lzchen

@lzchen
Copy link
Member

lzchen commented Sep 20, 2024

@lmolkova

We've had a discussion/contract with Azure-sdk architects that we will only add future (unstable) instrumentations only as an opt-in model (way back when we did our archboard review for GA for distro). This was part of our agreement to be able to include unstable components as part of a stable product (distro). Is this something that we can do for AI Inference Instrumentor as well?

@lzchen lzchen self-assigned this Oct 22, 2024
@lmolkova
Copy link
Member Author

Based on the offline discussion: azmon distro enables all Azure SDKs by default and we have a contract not to update semantic conventions in libraries until exporter supports a new version.

Azure AI Inference is one of Azure SDKs, but has a slightly different enablement mechanism, but follow the same contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
2 participants