Prevent unecessary Key Vault poller sleeping #9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
KeyVault
Client
chlowell
force-pushed
the
polling-improvement
branch
2 times, most recently
from
67ddf6a
to
8532a26
Compare
chlowell
force-pushed
the
polling-improvement
branch
from
8532a26
to
c236792
Compare
iscai-msft
approved these changes
Feb 27, 2020
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling methods currently sleep after every poll, even the one that completes the operation. This PR eliminates that unnecessary sleep, refactors the pollers to be somewhat simpler, and adds test coverage of them.