From 90a7da4740a53c048423640ed2f28d2aa460cc13 Mon Sep 17 00:00:00 2001 From: seankane-msft Date: Tue, 8 Dec 2020 12:27:40 -0800 Subject: [PATCH 1/7] adding code-coverage for just python39 --- .coveragerc | 3 ++- eng/pipelines/templates/jobs/archetype-sdk-tests.yml | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.coveragerc b/.coveragerc index 21aa73c31b30..d574f09a5b4d 100644 --- a/.coveragerc +++ b/.coveragerc @@ -12,4 +12,5 @@ exclude_lines = if raw: if custom_headers: if headers: - if response.status_code not in \ No newline at end of file + if response.status_code not in + if TYPE_CHECKING: \ No newline at end of file diff --git a/eng/pipelines/templates/jobs/archetype-sdk-tests.yml b/eng/pipelines/templates/jobs/archetype-sdk-tests.yml index ba5e8def96e6..0a7e2d65129f 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-tests.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-tests.yml @@ -18,18 +18,23 @@ parameters: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' Linux_PyPy3: OSVmImage: 'ubuntu-18.04' PythonVersion: 'pypy3' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9' + CoverageArg: '' CloudConfigurations: AzureCloud: SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources) @@ -39,7 +44,6 @@ jobs: - job: ${{ parameters.JobName }} variables: skipComponentGovernanceDetection: true - CoverageArg: --disablecov timeoutInMinutes: ${{ parameters.TestTimeoutInMinutes }} strategy: From 9352bc715a36bf6ae3c9d55794667d98ae4a95b3 Mon Sep 17 00:00:00 2001 From: seankane-msft Date: Tue, 8 Dec 2020 13:05:49 -0800 Subject: [PATCH 2/7] adding code coverage to individual tests.yml files --- sdk/eventhub/tests.yml | 4 ++++ sdk/formrecognizer/tests.yml | 8 ++++++++ sdk/monitor/tests.yml | 5 ++++- sdk/schemaregistry/tests.yml | 6 +++++- sdk/servicebus/tests.yml | 6 +++++- 5 files changed, 26 insertions(+), 3 deletions(-) diff --git a/sdk/eventhub/tests.yml b/sdk/eventhub/tests.yml index 6741921a7ce9..d9abf27e8080 100644 --- a/sdk/eventhub/tests.yml +++ b/sdk/eventhub/tests.yml @@ -9,15 +9,19 @@ jobs: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' + CoverageArg: '' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' EnvVars: AZURE_STORAGE_ACCOUNT: $(python-eh-livetest-event-hub-storage-account) AZURE_STORAGE_ACCESS_KEY: $(python-eh-livetest-event-hub-storage-access-key) diff --git a/sdk/formrecognizer/tests.yml b/sdk/formrecognizer/tests.yml index 19b875b9164a..19e93fb63d61 100644 --- a/sdk/formrecognizer/tests.yml +++ b/sdk/formrecognizer/tests.yml @@ -14,29 +14,37 @@ jobs: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' Linux_PyPy3: OSVmImage: 'ubuntu-18.04' PythonVersion: 'pypy3' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' + CoverageArg: '' ${{ if not(contains(variables['Build.DefinitionName'], 'prod')) }}: Matrix: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' + CoverageArg: '--disablecov' EnvVars: AZURE_FORM_RECOGNIZER_PYTHON_CANARY_API_KEY: $(python-formrecognizer-test-canary-api-key) AZURE_FORM_RECOGNIZER_PYTHON_API_KEY: $(python-formrecognizer-test-api-key) diff --git a/sdk/monitor/tests.yml b/sdk/monitor/tests.yml index bb4cbbf43e4e..96b3917ed15a 100644 --- a/sdk/monitor/tests.yml +++ b/sdk/monitor/tests.yml @@ -16,9 +16,12 @@ jobs: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' - PythonVersion: '3.9.0' \ No newline at end of file + PythonVersion: '3.9.0' + CoverageArg: '' \ No newline at end of file diff --git a/sdk/schemaregistry/tests.yml b/sdk/schemaregistry/tests.yml index d7efd31c2af1..abcfb788cbe9 100644 --- a/sdk/schemaregistry/tests.yml +++ b/sdk/schemaregistry/tests.yml @@ -20,12 +20,16 @@ jobs: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' Linux_Python38: OSVmImage: 'ubuntu-18.04' - PythonVersion: '3.8' \ No newline at end of file + PythonVersion: '3.8' + CoverageArg: '--disablecov' \ No newline at end of file diff --git a/sdk/servicebus/tests.yml b/sdk/servicebus/tests.yml index 9fa220ac1bb0..e41b8371c638 100644 --- a/sdk/servicebus/tests.yml +++ b/sdk/servicebus/tests.yml @@ -16,12 +16,16 @@ jobs: Linux_Python35: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.5' + CoverageArg: '--disablecov' MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' + CoverageArg: '--disablecov' Windows_Python27: OSVmImage: 'windows-2019' PythonVersion: '2.7' + CoverageArg: '--disablecov' Linux_Python39: OSVmImage: 'ubuntu-18.04' - PythonVersion: '3.9.0' \ No newline at end of file + PythonVersion: '3.9.0' + CoverageArg: '' \ No newline at end of file From f014b4d992b7f5bb416a17e86a444ebe4674030a Mon Sep 17 00:00:00 2001 From: seankane-msft Date: Tue, 8 Dec 2020 15:51:16 -0800 Subject: [PATCH 3/7] disabling code cov on monitor --- sdk/monitor/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/monitor/tests.yml b/sdk/monitor/tests.yml index 96b3917ed15a..a692d966c9a7 100644 --- a/sdk/monitor/tests.yml +++ b/sdk/monitor/tests.yml @@ -24,4 +24,4 @@ jobs: Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' - CoverageArg: '' \ No newline at end of file + CoverageArg: '--disablecov' \ No newline at end of file From d6363e4bbd5b2085091f626ac0b44bde771d68b6 Mon Sep 17 00:00:00 2001 From: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Date: Tue, 15 Dec 2020 16:45:06 -0500 Subject: [PATCH 4/7] Update sdk/formrecognizer/tests.yml Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> --- sdk/formrecognizer/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/formrecognizer/tests.yml b/sdk/formrecognizer/tests.yml index 19e93fb63d61..7afcd4afc876 100644 --- a/sdk/formrecognizer/tests.yml +++ b/sdk/formrecognizer/tests.yml @@ -44,7 +44,7 @@ jobs: Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' - CoverageArg: '--disablecov' + CoverageArg: '' EnvVars: AZURE_FORM_RECOGNIZER_PYTHON_CANARY_API_KEY: $(python-formrecognizer-test-canary-api-key) AZURE_FORM_RECOGNIZER_PYTHON_API_KEY: $(python-formrecognizer-test-api-key) From e3a5f032fc96a637a878e9372999867f43b73181 Mon Sep 17 00:00:00 2001 From: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Date: Tue, 15 Dec 2020 16:45:19 -0500 Subject: [PATCH 5/7] Update sdk/monitor/tests.yml Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> --- sdk/monitor/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/monitor/tests.yml b/sdk/monitor/tests.yml index a692d966c9a7..6082c9392d88 100644 --- a/sdk/monitor/tests.yml +++ b/sdk/monitor/tests.yml @@ -24,4 +24,4 @@ jobs: Linux_Python39: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.9.0' - CoverageArg: '--disablecov' \ No newline at end of file + CoverageArg: '' From d99d2d57ba6c547ce957aa53718efee2f7944575 Mon Sep 17 00:00:00 2001 From: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Date: Tue, 15 Dec 2020 16:45:33 -0500 Subject: [PATCH 6/7] Update sdk/eventhub/tests.yml Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> --- sdk/eventhub/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/eventhub/tests.yml b/sdk/eventhub/tests.yml index d9abf27e8080..0ead2ae7a14f 100644 --- a/sdk/eventhub/tests.yml +++ b/sdk/eventhub/tests.yml @@ -21,7 +21,7 @@ jobs: MacOs_Python37: OSVmImage: 'macOS-10.15' PythonVersion: '3.7' - CoverageArg: '--disablecov' + CoverageArg: '' EnvVars: AZURE_STORAGE_ACCOUNT: $(python-eh-livetest-event-hub-storage-account) AZURE_STORAGE_ACCESS_KEY: $(python-eh-livetest-event-hub-storage-access-key) From be0ab324abc253ccc3139659c197d5a4a0b148cb Mon Sep 17 00:00:00 2001 From: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Date: Tue, 15 Dec 2020 16:47:14 -0500 Subject: [PATCH 7/7] Update sdk/schemaregistry/tests.yml Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> --- sdk/schemaregistry/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/schemaregistry/tests.yml b/sdk/schemaregistry/tests.yml index abcfb788cbe9..683752b44788 100644 --- a/sdk/schemaregistry/tests.yml +++ b/sdk/schemaregistry/tests.yml @@ -32,4 +32,4 @@ jobs: Linux_Python38: OSVmImage: 'ubuntu-18.04' PythonVersion: '3.8' - CoverageArg: '--disablecov' \ No newline at end of file + CoverageArg: ''