Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up parameters of doc metadata release yaml file to CIConfig #1276

Closed
sima-zhu opened this issue Dec 11, 2020 · 1 comment
Closed

Clean up parameters of doc metadata release yaml file to CIConfig #1276

sima-zhu opened this issue Dec 11, 2020 · 1 comment
Assignees
@sima-zhu
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@sima-zhu
Copy link
Contributor

We currently maintain a long list of parameters in doc metadata yaml file.

Will use CiConfig json to summarize the parameters. If each artifact has special configs, we can define the CIConfig in ci.yml.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 11, 2020
@sima-zhu sima-zhu self-assigned this Dec 11, 2020
@sima-zhu sima-zhu added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 11, 2020
@sima-zhu sima-zhu mentioned this issue Dec 11, 2020
Merged
@sima-zhu
Copy link
Contributor Author

Lower the priority as following reasons:

  1. The CIConfigs in pipeline needs if/else conditions for overwriting.
  2. The custom setting has to take along all the setting in order to add new one.
  3. We have to parse the CiConfig before use, which complicated the use case.

Decided to move forward once we have more settings to handle over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sima-zhu sima-zhu

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sima-zhu