Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS SDK breaking change detection issue #5055

Closed
qiaozha opened this issue Jan 5, 2023 · 0 comments
Closed

JS SDK breaking change detection issue #5055

qiaozha opened this issue Jan 5, 2023 · 0 comments
Assignees
@dw511214992

Comments

@qiaozha
Copy link
Member

qiaozha commented Jan 5, 2023

Azure/azure-rest-api-specs#21190 In this PR, the last two JS breaking changes are just trying to add value into the union set, which should not be a breaking change but the detection tool count it as a breaking change.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 5, 2023
@dw511214992 dw511214992 removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 5, 2023
This was referenced Jan 16, 2023
Merged
Merged
@dw511214992 dw511214992 reopened this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dw511214992 dw511214992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dw511214992 @qiaozha