Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR Workflow][PR Summary] fails on README removal #6672

Closed
konrad-jamrozik opened this issue Aug 3, 2023 · 4 comments
Closed

[PR Workflow][PR Summary] fails on README removal #6672

konrad-jamrozik opened this issue Aug 3, 2023 · 4 comments
Assignees
@konrad-jamrozik
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Aug 3, 2023 •
edited
Loading

Workaround

If you are an author of a specs PR affected by this this issue, then revert README file removal from the PR.

Description

error checking PR summary
Error: ENOENT: no such file or directory, open 'specification/edgesites/resource-manager/readme.md'
    at Object.openSync (fs.js:498:3)
    at Object.readFileSync (fs.js:394:35)
    at new ReadmeParser (/mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/readmeUtils.js:38:35)
    at isRPSaaS (/mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/prSummary.js:305:26)
    at Object.ReadmeFile (/mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/prSummary.js:292:48)
    at /mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/prSummaryUtils.js:11:116
    at Array.forEach (<anonymous>)
    at /mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/prSummaryUtils.js:8:18
    at Array.forEach (<anonymous>)
    at Object.processPrChanges (/mnt/vss/_work/1/a/unified-pipeline-runtime/public/rest-api-specs-scripts/dist/prSummaryUtils.js:7:12) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: 'specification/edgesites/resource-manager/readme.md'
}

Rerunning with /azp run doesn't help.
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Aug 3, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Aug 3, 2023
@konrad-jamrozik konrad-jamrozik added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Aug 3, 2023
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Aug 8, 2023 •
edited
Loading

Another case:

@konrad-jamrozik konrad-jamrozik changed the title [PR Workflow] PR summary fails on README removal [PR Workflow][PR Summary] fails on README removal Aug 18, 2023
@konrad-jamrozik
Copy link
Contributor Author

Another case:

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jan 26, 2024 •
edited
Loading

Another case:

Bumping priority of this item.

@weshaggard FYI

@konrad-jamrozik konrad-jamrozik mentioned this issue Jan 26, 2024
Merged
6 tasks
@konrad-jamrozik konrad-jamrozik added the openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ label Jan 27, 2024
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jan 27, 2024 •
edited
Loading

  • Pull Request 524427: Fix incorrect file diffs for READMEs, thus bugfixing issues with readme removal

Confirmed the fix works on two PRs:

@konrad-jamrozik konrad-jamrozik mentioned this issue Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. openapi-alps Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/ Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 📈
Archived in project
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konrad-jamrozik