Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Openapi-Diff] Removals are not reported in cross version breaking change CI check #6765

Closed
raych1 opened this issue Aug 14, 2023 · 2 comments
Closed

[Openapi-Diff] Removals are not reported in cross version breaking change CI check #6765

raych1 opened this issue Aug 14, 2023 · 2 comments
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@raych1
Copy link
Member

raych1 commented Aug 14, 2023 •
edited
Loading

This is the repro PR:
Azure/azure-rest-api-specs#24771

In this PR, there're a bunch of removals comparing to previous version 2023-06-01-preview but they're not reported in the cross version breaking change result. such as: ExportPipeline, ExportPipelineListResult, ExportPipelineProperties, etc.

This issue would result in the breaking change review ignoring these changes.
@raych1 raych1 added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Aug 14, 2023
@raych1
Copy link
Member Author

raych1 commented Aug 14, 2023

I found they're reported as warnings. Closed this issue to confirm with Mike.

@raych1 raych1 closed this as completed Aug 14, 2023
@github-project-automation github-project-automation bot moved this to 🎊 Closed in Spec PR Tools Aug 14, 2023
@AntonioVT
Copy link
Member

Just to add to the discussion, those "removals" are from features that are in preview versions but are not ready to be GA'd/stable. They will be for sure included in the next preview API release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AntonioVT @raych1