Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change][PR Workflow] azure-rest-api-specs PR checks should block merge of preview and stable with same version date #7294

Open
mikekistler opened this issue Nov 15, 2023 · 1 comment
Assignees
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

The Azure Versioning and Breaking Changes Policy requires that the version-date of a preview version be later than the most recent stable version. However, this rule does not appear to be enforced by our current PR pipeline checks, since just two months ago Cosmos DB released a stable and preview version with the same date -- 2023-09-15 and 2023-09-15-preview.

The stable 2023-09-15 version was added in PR 25266 which merged to main on Sept 22.

The preview 2023-09-15-preview version was added in PR 25326 which merged to main on Sept 20.

Since the preview merged before the stable version, the stable version merge should have been blocked as violating the Azure Versioning policy.

@mikekistler mikekistler added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Nov 15, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Nov 27, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Nov 27, 2023
@konrad-jamrozik konrad-jamrozik changed the title azure-rest-api-specs PR checks should block merge of preview and stable with same version date [Breaking Change][PR Workflow] azure-rest-api-specs PR checks should block merge of preview and stable with same version date Nov 27, 2023
@konrad-jamrozik
Copy link
Contributor

This is one of the many improvements to be made to breaking change detection. For more, see:

and issues hyperlinked within.

@konrad-jamrozik konrad-jamrozik added the Breaking Changes Improvements to Breaking Changes tooling label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

2 participants