Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the misleading link logging in PR validation. #984

Closed
sima-zhu opened this issue Sep 10, 2020 · 1 comment · Fixed by #895
Closed

Fix the misleading link logging in PR validation. #984

sima-zhu opened this issue Sep 10, 2020 · 1 comment · Fixed by #895
Assignees
@sima-zhu
Labels
EngSys This issue is impacting the engineering system.

Comments

@sima-zhu
Copy link
Contributor

sima-zhu commented Sep 10, 2020 •
edited
Loading

We do link replacement when the pipeline triggered by a PR. However, we print out the replacement link instead of origin master link in our log. Need to fix it and print original master link.

image
@sima-zhu sima-zhu self-assigned this Sep 10, 2020
@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Sep 10, 2020
@sima-zhu sima-zhu changed the title Fix the misleading link in PR validation. Fix the misleading link logging in PR validation. Sep 10, 2020
@sima-zhu sima-zhu mentioned this issue Sep 14, 2020
Merged
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Sep 15, 2020 •
edited
Loading

Will be solved by #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sima-zhu sima-zhu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failed the validation when use relative links sima-zhu/azure-sdk-tools
1 participant
@sima-zhu