From 9544c537718e58a59f9a1586f5b468d26471d63c Mon Sep 17 00:00:00 2001 From: Christian Muirhead Date: Wed, 7 Apr 2021 10:58:41 +1200 Subject: [PATCH] Review feedback, thanks @matthchr --- pkg/resourcemanager/rediscaches/redis/rediscache_reconcile.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/resourcemanager/rediscaches/redis/rediscache_reconcile.go b/pkg/resourcemanager/rediscaches/redis/rediscache_reconcile.go index f127c2a5e41..36a8d0a71cf 100644 --- a/pkg/resourcemanager/rediscaches/redis/rediscache_reconcile.go +++ b/pkg/resourcemanager/rediscaches/redis/rediscache_reconcile.go @@ -50,13 +50,13 @@ func (rc *AzureRedisCacheManager) Ensure(ctx context.Context, obj runtime.Object instance.Status.Message = err.Error() return false, err } - instance.Status.State = string(newRc.ProvisioningState) if newRc.StaticIP != nil { instance.Status.Output = *newRc.StaticIP } instance.Status.ResourceId = *newRc.ID + instance.Status.State = string(newRc.ProvisioningState) instance.Status.SetProvisioned(resourcemanager.SuccessMsg) return true, nil } @@ -90,8 +90,6 @@ func (rc *AzureRedisCacheManager) Ensure(ctx context.Context, obj runtime.Object instance.Status.SetProvisioning("RedisCache exists but may not be ready") return false, nil } else if helpers.ContainsString(catchKnownError, azerr.Type) { - // TODO: Not sure why we want this to be provisioning=false? - instance.Status.Provisioning = false return false, nil } else { // serious error occured, end reconcilliation and mark it as failed