Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Modify Managed Identity script to have option to create identity, and not deploy aad-pod-identity #1123

Closed
1 task
cnadolny opened this issue Jun 1, 2020 · 2 comments
Labels
low-priority Low priority item. We'll get to it eventually.

Comments

@cnadolny
Copy link
Contributor

cnadolny commented Jun 1, 2020

Currently, the managed identity script will provision a managed identity, assign it permissions, and then install and create the required aad-pod-identity components into the cluster.

It would be useful to give the script functionality, perhaps with a flag, to provision the identity and permissions, and then print out the resource and client ID to the command line for the user.

The user would then be able to take the output client and resource ID and be able to use it with the Helm Chart.

The managed identity docs also do not provide manual instructions anymore on how to create a managed identity:
https://github.com/Azure/azure-service-operator/blob/master/docs/howto/managedidentity.md

Done criteria
This is the "done" criteria for this task

  • Script is modified, and Helm docs are updated
@cnadolny cnadolny added the task label Jun 1, 2020
@jananivMS jananivMS added low-priority Low priority item. We'll get to it eventually. triaged labels Jun 23, 2020
@r-t-m
Copy link

r-t-m commented Jul 2, 2020

I would like to add that user can have aad-pod-identity already deployed in the cluster and the only thing needed in that case is to specify which managed identity to use without any dependency installation. Besides that this will allow aad pod identity to be updated separately faster than ASO maintainers update it the chart.

@matthchr
Copy link
Member

matthchr commented Dec 1, 2020

I removed the existing script entirely in favor of clearly documenting how to create an identity (if needed). This allows customers more freedom to pick exactly the permissions they want to assign to the identity.

See: https://github.com/Azure/azure-service-operator/blob/master/docs/howto/managedidentity.md

@matthchr matthchr closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low priority item. We'll get to it eventually.
Projects
None yet
Development

No branches or pull requests

4 participants