Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Rename storage account secret name #1152

Closed
1 task
melonrush13 opened this issue Jun 8, 2020 · 1 comment
Closed
1 task

Task: Rename storage account secret name #1152

melonrush13 opened this issue Jun 8, 2020 · 1 comment

Comments

@melonrush13
Copy link
Contributor

Currently, the storage account secret displays as the following when doing a k get secret

10471 ± k get secret                                                                                                                                                
NAME                                           TYPE                                  DATA   AGE                                5      96m
storageaccount-rg-expotest-dev-saexpotestdev   Opaque                                5      93m
erins-MBP ॐ  ~/go/src/github.com/frodopwns/exposure-notifications-server/examples/aso-dev-deploy:(18h1m|git@chartdraft!)

10472 ± k get storageaccount                                                                                                                                        
NAME            PROVISIONED   MESSAGE
saexpotestdev   true          successfully provisioned

We should rename the secret storageaccount-rg-expotest-dev-saexpotestdev to the standard naming convention across controllers for secrets, or something more declarative.

Done criteria
Rename the name of the storage account secret to the standard naming convention across containers.

  • For eg. After this task is done, the user should be able to use either webhooks or the declarative model for K8s

User story reference

#

@matthchr
Copy link
Member

matthchr commented Feb 4, 2021

This has been fixed by #1358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants