Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add liveness/readiness probes #1201

Closed
frodopwns opened this issue Jun 30, 2020 · 2 comments · Fixed by #2254
Closed

Task: Add liveness/readiness probes #1201

frodopwns opened this issue Jun 30, 2020 · 2 comments · Fixed by #2254
Assignees
Milestone

Comments

@frodopwns
Copy link
Contributor

The initial health checking probe was removed in #1198 to avoid issues where the Kubelet could not connect to the health endpoint on some clusters. The initial check was only doing a naive check anyway. We should regroup and investigate what these endpoints should actually do in order to ensure the operator is functioning and the reintroduce the code changes.

@babbageclunk
Copy link
Member

We should check how to do this in controller-runtime and whether we can add custom health logic.

@babbageclunk babbageclunk added this to the codegen-beta-1 milestone Dec 6, 2021
@matthchr
Copy link
Member

We still think this is worth investigating. @super-harsh was looking at this some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

5 participants