Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish chart versions that are SemVer 2 compatible #3189

Closed
kengibous opened this issue Aug 16, 2023 · 5 comments · Fixed by #3222
Closed

Publish chart versions that are SemVer 2 compatible #3189

kengibous opened this issue Aug 16, 2023 · 5 comments · Fixed by #3222
Assignees
Milestone

Comments

@kengibous
Copy link

Describe the current behavior
Currently chart versions are being published with a prefix, "v" (example v2.2.0) which is not SemVer 2 compatible. Such charts like aad-pod-identity are not including "v" in the version.

Describe the improvement
Consider dropping the "v" from publish charts so that the helm manifest provides SemVer 2 compatible versions.

Additional context
I believe the change could be as straightforward as changing - https://github.com/Azure/azure-service-operator/blob/main/v2/charts/azure-service-operator/Chart.yaml#L3 - to version: 2.2.0

@matthchr
Copy link
Member

We'll look into this - need to think about impact on existing users, etc as well.

@matthchr
Copy link
Member

Looking at other tools:
https://artifacthub.io/packages/helm/cert-manager/cert-manager doesn't have a v prefix for the chart version.
https://artifacthub.io/packages/helm/prometheus-community/prometheus - also no v prefix.

helm docs also suggest we probably shouldn't have a prefix: https://helm.sh/docs/chart_best_practices/conventions/#version-numbers

If we were to make this change, I think we'd make it only going forward (so 2.3.0).

@kengibous
Copy link
Author

@matthchr sounds good, I appreciate the consideration.

@kengibous
Copy link
Author

@matthchr - i see that version 2.30 is released, but i do not see a published chart

@matthchr
Copy link
Member

matthchr commented Sep 6, 2023

There was an issue with the 2.3.0 chart (unrelated to this issue). See #3259. We're fixing that and will republish the chart later today.

Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants