-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish chart versions that are SemVer 2 compatible #3189
Comments
We'll look into this - need to think about impact on existing users, etc as well. |
Looking at other tools: helm docs also suggest we probably shouldn't have a prefix: https://helm.sh/docs/chart_best_practices/conventions/#version-numbers If we were to make this change, I think we'd make it only going forward (so |
@matthchr sounds good, I appreciate the consideration. |
@matthchr - i see that version 2.30 is released, but i do not see a published chart |
There was an issue with the 2.3.0 chart (unrelated to this issue). See #3259. We're fixing that and will republish the chart later today. Sorry about that |
Describe the current behavior
Currently chart versions are being published with a prefix, "v" (example v2.2.0) which is not SemVer 2 compatible. Such charts like aad-pod-identity are not including "v" in the version.
Describe the improvement
Consider dropping the "v" from publish charts so that the helm manifest provides SemVer 2 compatible versions.
Additional context
I believe the change could be as straightforward as changing - https://github.com/Azure/azure-service-operator/blob/main/v2/charts/azure-service-operator/Chart.yaml#L3 - to
version: 2.2.0
The text was updated successfully, but these errors were encountered: