Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASO helm chart should allow specifying affinity and tolerations for pod deployments. #3646

Closed
Roman-Galeev opened this issue Dec 13, 2023 · 3 comments · Fixed by #3765
Closed

ASO helm chart should allow specifying affinity and tolerations for pod deployments. #3646

Roman-Galeev opened this issue Dec 13, 2023 · 3 comments · Fixed by #3765
Assignees
@super-harsh
Labels
good-first-issue issues which would be a good starting point for newcomers to the codebase new-feature
Milestone
v2.6.0

Comments

@Roman-Galeev
Copy link

Otherwise the deployment may stuck for clusters configured with node taints.
@matthchr matthchr added the good-first-issue issues which would be a good starting point for newcomers to the codebase label Jan 8, 2024
@matthchr
Copy link
Member

matthchr commented Jan 8, 2024

We have podAnnotations but agree it seems like it would be good to have more control than that.

@matthchr matthchr added this to the v2.6.0 milestone Jan 8, 2024
@matthchr matthchr changed the title BUG: ASO helm chart should allow specifying affinity and tolerations for pod deployments. ASO helm chart should allow specifying affinity and tolerations for pod deployments. Jan 8, 2024
@Roman-Galeev
Copy link
Author

Yeah, podAnnotations are a bit different. When cluster nodes are tainted, tolerations is the only way to allow deployments.

@matthchr
Copy link
Member

matthchr commented Jan 9, 2024

Ah yeah sorry, wasn't trying to imply that podAnnotations solved your problem, just saying I think these newly proposed fields could go next to that.

@super-harsh super-harsh mentioned this issue Feb 7, 2024
Merged
@super-harsh super-harsh self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@super-harsh super-harsh

Labels
good-first-issue issues which would be a good starting point for newcomers to the codebase new-feature
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Add affinity and tolerations to ASOv2 helm chart Azure/azure-service-operator
3 participants
@matthchr @super-harsh @Roman-Galeev