Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Securely serve metrics using controller-runtime, instead of kube-rbac-proxy #3741

Closed
dlipovetsky opened this issue Jan 25, 2024 · 0 comments · Fixed by #3833
Closed
Assignees
Milestone

Comments

@dlipovetsky
Copy link

Today, ASO securely serves metrics with kube-rbac-proxy. It can do this with controller-runtime itself, using a feature added in kubernetes-sigs/controller-runtime#2407, and available since the v0.16.0 release. This allows ASO to drop its dependency on kube-rbac-proxy.

For reference, the cluster-api core project motivated the above work, which it integrated in kubernetes-sigs/cluster-api#9264. Some years ago, cluster-api used to deploy kube-rbac-proxy, but removed it in kubernetes-sigs/cluster-api#4640.

Related slack conversation: https://kubernetes.slack.com/archives/C046DEVLAQM/p1706203810505779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants