Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented breaking change to azure.storage.blob.baseblobservice.BaseBlobService.generate_blob_shared_access_signature in 2.0 #595

Closed
taymonbeal opened this issue May 15, 2019 · 1 comment

Comments

@taymonbeal
Copy link

Which service(blob, file, queue) does this issue concern?

Blob

Which version of the SDK was used? Please provide the output of pip freeze.

azure-common==1.1.20
azure-storage-blob==2.0.1
azure-storage-common==2.0.0

What problem was encountered?

azure.storage.blob.baseblobservice.BaseBlobService.generate_blob_shared_access_signature acquired a new parameter, snapshot, in 2.0. This parameter was inserted before permission. This breaks code that passes permission positionally. Notably, django-storages does this.

Have you found a mitigation/solution?

Patch dependents to pass permission by keyword.

@zezha-msft
Copy link
Contributor

zezha-msft commented Jun 4, 2019

Hi @taymonbeal, thanks for reaching out!

Sorry for the inconvenience! We'll make sure to be more explicit in the changelog in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants