[AVM Module Issue]: Improve setup of database account properties #3910
Labels
Class: Resource Module 📦
This is a resource module
Needs: Triage 🔍
Maintainers need to triage still
Status: Response Overdue 🚩
When an issue/PR has not been responded to for X amount of days
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Feature Request ➕
New feature or request
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/document-db/database-account
(Optional) Module Version
0.10.0
Description
Currently, there are multiple issues raised due to the fact that always at least one "dummy" database needs to be set to be able to set correctly database account properties.
The problematic code is here:
I see an issue using databases properties here as for initial provisioning users usually do not need to have database/collection and will set them up later and with separate provisioning.
I would recommend following:
The majority of configs are relevant for all API types and database flavors. Even your check goes over all supported "databases" so it is easy to move it to common configuration.
The key is to not enforce creating "dummy" databases but setup database account correctly also without them.
Having additional discriminator parameter will help and will make the choose transparently to module users.
I hope you consider this improvement.
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: