Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator cmd to allow configurable logging level and default it to 'warning' #921

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jun 24, 2022

This PR removes the verbose flag from the generator command and adds a logging-level command that takes a logging level supported by autorest. By default, the level of 'warning' will be used; previously, autorest would be run at the 'information' logging level (or 'debug' if the --verbose flag was supplied), which has been generating a number of log entries that will often (or always) vary between generator runs, leading to some fairly noisy PRs.

@codecov-commenter
Copy link

Codecov Report

Merging #921 (f893e05) into main (9bb53e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          18       18           
  Lines         294      294           
=======================================
  Hits          281      281           
  Misses         13       13           
Flag Coverage Δ
dotnet 95.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@jeskew jeskew merged commit 4d71c0f into main Jun 24, 2022
@jeskew jeskew deleted the jeskew/reduce-generator-log-verbosity branch June 24, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants