Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still maintained? #66

Open
migg24 opened this issue Jan 31, 2024 · 5 comments
Open

Is this project still maintained? #66

migg24 opened this issue Jan 31, 2024 · 5 comments
Labels
need-to-triage Requires investigation

Comments

@migg24
Copy link

migg24 commented Jan 31, 2024

Last real update is from 2022, a nice PR updating to node 20 is open and needed, but ignored. As well as other open issues.

Is there still somebody here maintaining the action?

@migg24 migg24 added the need-to-triage Requires investigation label Jan 31, 2024
@soderlind
Copy link

I replaced this action with docker/login-action

        name: Login to ACR
        uses: docker/login-action@v3
        with:
          registry: <registry-name>.azurecr.io
          username: ${{ secrets.AZURE_CLIENT_ID }}
          password: ${{ secrets.AZURE_CLIENT_SECRET }}

docker/login-action@v3 uses Node 20 as default runtime.

@Shelrothman
Copy link

Thank you @soderlind, that worked great for me

@christianblueskylabs
Copy link

My first time using Azure and following the instructions as seen in here. Lost quite a handful of hours figuring out why pushing to ACR on my GitHub Actions kept on failing with unauthorized: authentication required, visit https://aka.ms/acr/authorization for more information. Swapped azure/docker-login@v1 for docker/login-action@v3 and it finally worked, what?

@kohtala
Copy link

kohtala commented Mar 19, 2024

I came here looking if this has improved since I evaluated and rejected this action. Nothing has improved. It still has all the problems and now even more without node20.

  • This action modifies directly the docker configuration file.
  • We use federated authentication with azure/login and I'm not sure if this would work even if I took the token from azure/login and saved it as password for the magic 00000000-0000-0000-0000-000000000000 user. It should do the magic automatically.
  • It has no run.post step to remove the token, so bad leaving credentials laying on self-hosted runners.

For us it is better to just run az acr login (a wrapper for docker login that digs the credentials from azure/login for us) and run docker logout as an if: always() step later in the workflow.

@lgmorand
Copy link
Collaborator

lgmorand commented May 21, 2024

it's not maintained anymore. Original team does not had bandwidth to maintain it. I just asked the access to upgrade to node20. that's it. don't expect any improvment/new feature which is not pushed by the community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-to-triage Requires investigation
Projects
None yet
Development

No branches or pull requests

6 participants