Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion from untyped int to string yields a string of one rune, not a string of digits - in parser_test.go #30

Open
advancedwebdeveloper opened this issue Oct 11, 2020 · 4 comments

Comments

@advancedwebdeveloper
Copy link

Hi.
Your test is crashing:

$ go test ./...

_/home/oceanfish81/go_projects/go-ansiterm

./parser_test.go:133:32: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./parser_test.go:135:31: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL _/home/oceanfish81/go_projects/go-ansiterm [build failed]
FAIL

I am using gollvm :

$ go version
go version go1.15.2 gollvm LLVM 12.0.0git linux/amd64

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oceanfish81/.cache/go-build"
GOENV="/home/oceanfish81/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/oceanfish81/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oceanfish81/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/oceanfish81/gollvm_dist"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/oceanfish81/gollvm_dist/tools"
GCCGO="/home/oceanfish81/gollvm_dist/bin/llvm-goc"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build468415241=/tmp/go-build -gno-record-gcc-switches -funwind-tables"

Could be reproduced using my "release" build

@advancedwebdeveloper
Copy link
Author

advancedwebdeveloper commented Oct 11, 2020

@ianlancetaylor
Copy link

This is the new warning described at https://golang.org/doc/go1.15#vet .

@advancedwebdeveloper
Copy link
Author

@jstarks , @gabrielhartmann : would you offer a patch?

@Akaame
Copy link

Akaame commented Oct 10, 2021

Hello @advancedwebdeveloper,

This commit by @eclipseo addressed this issue.

Passing tests with latest gollvm

image

Could someone please close this issue as fixed? @jstarks @ahmetb @cpuguy83

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants