Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model validation issues for Search dataplane swagger spec #234

Closed
amarzavery opened this issue Apr 12, 2018 · 3 comments
Closed

Fix model validation issues for Search dataplane swagger spec #234

amarzavery opened this issue Apr 12, 2018 · 3 comments

Comments

@amarzavery
Copy link
Contributor

It seems there is a bug in the regex validation for paths since path contains special characters like "(" and ")" which then causes the tool to incorrectly report path parameters that were provided in the example.

Another bug seems to be around validating polymorphic types.

Please take a look at the CI job and also follow all the pain points pointed by Bruce Johnston in the PR conversation.
@brjohnstmsft brjohnstmsft mentioned this issue Apr 13, 2018
Merged
10 tasks
@mcardosos mcardosos self-assigned this Apr 16, 2018
@mcardosos
Copy link
Contributor

Did not find issues with polymorphism.
However found issues with parametrized-host. Open issue here #240

@salameer salameer reopened this May 3, 2018
@salameer salameer closed this as completed May 3, 2018
@amarzavery amarzavery reopened this May 4, 2018
@amarzavery amarzavery mentioned this issue May 4, 2018
Closed
@Azure Azure deleted a comment from mcardosos May 4, 2018
@amarzavery amarzavery mentioned this issue May 4, 2018
Closed
@amarzavery
Copy link
Contributor Author

Part 1 - #243 fixed.
Part 2 - #240 needs to be fixed.

@sarangan12 sarangan12 mentioned this issue May 14, 2018
Closed
@sarangan12
Copy link
Member

Part 2 - Fixed
Part 3 - #248 . needs to be fixed

@vladbarosan vladbarosan mentioned this issue Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sarangan12 @amarzavery @vladbarosan @salameer @mcardosos