[Mellanox] Enhance Platform API to support SN2201 - RJ45 ports and new components mgmt. #10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Do not check ONIE version on SN2201. In legacy switches, upgrading firmware from ONIE was supported from a certain version while it is supported from the very beginning on SN2201. So we do not need to check ONIE version on SN2201 Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
1. A derived class representing RJ45 ports is introduced. get_presence always returns True 2. SFP error event is leveraged to represent "unknown" and "not present" states. By doing so, most of code change for supporting RJ45 is restricted in platform API and CLI xcvrd won't need to be updated for this Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
- Hide the logic to convert port_change to error_dict inside sfp_event - In case there are some RJ45 ports are down (not present), report them as sfp_event during the first round of get_change_event This is because SDK/FW will never report port change occurred before init We must make compensation for it in platform API Signed-off-by: Stephen Sun <stephens@nvidia.com>
- Report unknown event for RJ45 ports - Fix syntax error Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…s_index_return [] Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…sd fw update scripts Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
keboliu
requested review from
sujinmkang,
prgeor,
vdahiya12 and
lguohan
as code owners
stephenxs
approved these changes
Mar 21, 2022
|
This pull request introduces 2 alerts when merging 7232264 into 1017ee6 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The solution is to inherit a class from sfp_base to manage RJ45 ports, this class will only return the port type with "RJ45",
other fields will left with 'N/A', so XCVRD still can have a "TRANCEIVER_INFO|Ethernetx" populated to DB with type="RJ45" against a RJ45 port, and this new class will reject the lpmode, reset, etc. APIs call.
How I did it
How to verify it
Run platform test on SN2201 platform
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)