Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-buildimage] New feature managementVRF(L3mdev) #2585

Merged
merged 1 commit into from
Jul 24, 2019
Merged

[sonic-buildimage] New feature managementVRF(L3mdev) #2585

merged 1 commit into from
Jul 24, 2019

Conversation

vharish02
Copy link
Contributor

This commit adds support for New feature management VRF using L3mdev.
Added commands to enable/disable management VRF. Config vrf add mgmt
will enable management VRF, enslave the eth0 device to the master
device mgmt, stop ntp service in default, restart interfaces-configs
and restart ntp service in mgmt-vrf context.
management interface (eth0) can be configured using config interface eth0 ip add
command and removed using config interface eth0 ip remove command.
Requirement and design are covered in mgmt vrf design document.
Currently show command displays Linux command output, will update show
command display in next PR after concluding what would be the output for the
show commands. Added metric for default routes in dhcp and static, any changes
for metric will be addressed subsequently after discussing.

Signed-off-by: Harish Venkatraman harish_venkatraman@dell.com

- What I did
Added support for new feature management VRF using l3mdev.
- How I did it
Added commands to enable and disable management VRF using config commands and displays the management VRF information using show commands.
Added support to configure eth0 (management interface) ip address

- How to verify it
Verified by running the below commands for configuring management VRF and delete management VRF
config vrf add mgmt
config vrf del mgmt
Use the below command to configure eth0 ip address.
config interface eth0 ip add ip/mask gatewayIP
Ex: config interface eth0 ip add 10.11.100.11/24 10.11.100.1
config interface eth0 ip remove ip/mask
config interface eth0 ip remove10.11.100.11/24
Verified NTP using below steps

  • Added NTP_SERVERS in config_db.json
  • Load config_db.json
  • restart ntp.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vharish02 vharish02 force-pushed the management_vrf_support branch from 6b68451 to 179dbc7 Compare February 18, 2019 21:59
@lguohan lguohan requested a review from nikos-github February 20, 2019 05:56
@vharish02 vharish02 force-pushed the management_vrf_support branch from 179dbc7 to 2bdb064 Compare June 15, 2019 05:36
@vharish02 vharish02 force-pushed the management_vrf_support branch from 2bdb064 to c73693e Compare June 26, 2019 11:28
@lguohan lguohan requested a review from pavel-shirshov July 9, 2019 00:45
pavel-shirshov
pavel-shirshov approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please wait for others approvals

lguohan
lguohan requested changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to split the pr into two, one for mvrf only, one for moving ntpd to mvrf.

@vharish02
Copy link
Contributor Author

suggest to split the pr into two, one for mvrf only, one for moving ntpd to mvrf.
will do

@vharish02
Copy link
Contributor Author

suggest to split the pr into two, one for mvrf only, one for moving ntpd to mvrf.

will do

@vharish02 vharish02 force-pushed the management_vrf_support branch from c73693e to 166039c Compare July 22, 2019 21:55
@lguohan
Copy link
Collaborator

lguohan commented Jul 23, 2019

since ifupdown2 1.28 is installed, can you remove ifupdown2 from your PR?

[sonic-buildimage] New feature managementVRF(L3mdev)
5a1ae53 
This commit adds support for New feature management VRF using L3mdev.  Added
commands to enable/disable management VRF. Config vrf add mgmt will enable
management VRF, enslave the eth0 device to the master device mgmt and restart
interfaces-configs in mgmt-vrf context.

management interface (eth0) can be configured using config interface eth0 ip
add command and removed using config interface eth0 ip remove command.

Requirement and design are covered in mgmt vrf design document.  Currently show
command displays linux command output; will update show command display in next
PR after concluding what would be the output for the show commands. Added
metric for default routes in dhcp and static, any changes for metric will be
addressed subsequently after discussing.

Signed-off-by: Harish Venkatraman <harish_venkatraman@dell.com>
@vharish02 vharish02 force-pushed the management_vrf_support branch from 166039c to 5a1ae53 Compare July 23, 2019 21:40
@vharish02
Copy link
Contributor Author

since ifupdown2 1.28 is installed, can you remove ifupdown2 from your PR?

done

@lguohan
Copy link
Collaborator

lguohan commented Jul 24, 2019

retest vsimage please

@lguohan lguohan merged commit 3e69427 into sonic-net:master Jul 24, 2019
@batmancn
Copy link

batmancn commented Oct 21, 2019 •
edited
Loading

I have few questions:

  • what's "up cgcreate -g l3mdev:mgmt" and "up cgset -r l3mdev.master-device=mgmt mgmt" used for? And why I got "-bash: cgcreate: command not found" error?
  • where is "mgmt vrf design document" you mentioned?
  • VRF table changed from 1001 to 5000, is there some consideration?

@cony7642 cony7642 mentioned this pull request Dec 3, 2019
Merged
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jan 11, 2023
@dprital
[submodule] Advance sonic-utilities pointer
e05747b 
Update sonic-utilities submodule pointer to include the following:
* fb8f98b Preserve copp tables through DB migration ([sonic-net#2524](sonic-net/sonic-utilities#2524))
* 4aa512c [sfputil] Firmware download/upgrade CLI support for QSFP-DD (sonic-net#1947) ([sonic-net#2349](sonic-net/sonic-utilities#2349))
* f63ef9a Revert sonic-utilities: Update config reload() to verify formatting of an input file (sonic-net#2529) ([sonic-net#2586](sonic-net/sonic-utilities#2586))
* 3a09ecb [masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links ([sonic-net#2466](sonic-net/sonic-utilities#2466))
* 65cf00a [storyteller] add link prober state change to story teller ([sonic-net#2585](sonic-net/sonic-utilities#2585))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Jan 12, 2023
@dprital
[submodule] Advance sonic-utilities pointer (#13333)
d9c75b3 
Update sonic-utilities submodule pointer to include the following:
* fb8f98b Preserve copp tables through DB migration ([#2524](sonic-net/sonic-utilities#2524))
* 4aa512c [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947) ([#2349](sonic-net/sonic-utilities#2349))
* f63ef9a Revert sonic-utilities: Update config reload() to verify formatting of an input file (#2529) ([#2586](sonic-net/sonic-utilities#2586))
* 3a09ecb [masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links ([#2466](sonic-net/sonic-utilities#2466))
* 65cf00a [storyteller] add link prober state change to story teller ([#2585](sonic-net/sonic-utilities#2585))

Signed-off-by: dprital <drorp@nvidia.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jan 12, 2023
@yxieca
[202205][utilities][swss][sairedis][platform-daemons] advance submodu…
fe7b212 
…le head

utilties:
* 7fc3fb7 2023-01-06 | [storyteller] add link prober state change to story teller (sonic-net#2585) (HEAD -> 202205, github/202205) [Jing Zhang]
* d8202e8 2023-01-12 | [202205] Added a new option in show queue counters command to display voq statistics (sonic-net#2591) [Sambath Kumar Balasubramanian]
* 98dde31 2023-01-11 | resolved conflicts (sonic-net#2589) [kannankvs]

swss:
* 268c3f3 2023-01-11 | Added new attributes for Vnet and Vxlan ecmp configurations. (sonic-net#2584) (HEAD -> 202205, github/202205) [siqbal1986]
* 50235b6 2023-01-12 | [routesync] Fix for stale dynamic neighbor (sonic-net#2553) [vganesan-nokia]
* ad9d826 2023-01-12 | [202205][voq] Add voq counters. (sonic-net#2606) [Sambath Kumar Balasubramanian]
* 34995f1 2023-01-10 | Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2612) [Arvindsrinivasan Lakshmi Narasimhan]

sairedis:
* 92e6442 2023-01-05 | enable cisco8000 SAI bulk API feature (sonic-net#1153) (sonic-net#1164) (github/202205) [Keith Lu]

platform-daemons:
* 10eb2e6 2023-01-06 | Fix bug where transceiver info is missing after port breakout change (sonic-net#329) (HEAD -> 202205) [Tal Berlowitz]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Jan 12, 2023
Merged
yxieca added a commit that referenced this pull request Jan 13, 2023
@yxieca
[202205][utilities][swss][sairedis][platform-daemons] advance submodu…
9bfb70e 
…le head (#13353)

utilties:
* 7fc3fb7 2023-01-06 | [storyteller] add link prober state change to story teller (#2585) (HEAD -> 202205, github/202205) [Jing Zhang]
* d8202e8 2023-01-12 | [202205] Added a new option in show queue counters command to display voq statistics (#2591) [Sambath Kumar Balasubramanian]
* 98dde31 2023-01-11 | resolved conflicts (#2589) [kannankvs]

swss:
* 268c3f3 2023-01-11 | Added new attributes for Vnet and Vxlan ecmp configurations. (#2584) (HEAD -> 202205, github/202205) [siqbal1986]
* 50235b6 2023-01-12 | [routesync] Fix for stale dynamic neighbor (#2553) [vganesan-nokia]
* ad9d826 2023-01-12 | [202205][voq] Add voq counters. (#2606) [Sambath Kumar Balasubramanian]
* 34995f1 2023-01-10 | Revert "[voq][chassis]Add show fabric counters port/queue commands (#2522)" (#2612) [Arvindsrinivasan Lakshmi Narasimhan]

sairedis:
* 92e6442 2023-01-05 | enable cisco8000 SAI bulk API feature (#1153) (#1164) (github/202205) [Keith Lu]

platform-daemons:
* 10eb2e6 2023-01-06 | Fix bug where transceiver info is missing after port breakout change (#329) (HEAD -> 202205) [Tal Berlowitz]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@StormLiangMS StormLiangMS mentioned this pull request Feb 11, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this pull request Feb 17, 2023
@StormLiangMS
[submodules] advance submodules for 202211 #13781
1d155b8 
Why I did it
Submodule advances:
sonic-utilities

8e8e6088 - [202211][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan ([201811 sub-module] advance sub-modules: utilities, swss, swss-common #2679) (16 hours ago) [Yaqiang Zhu]
1400fb94 - [GCU] Ignore bgpraw in GCU applier (Fix sfputil indexing for 7170-Q59S20 #2623) (15 hours ago) [jingwenxie]
f76a6364 - [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan ([sonic-py-swsssdk] Update submodule #2660) (15 hours ago) [Yaqiang Zhu]
7849e18d - [db_migrator] make LOG_LEVEL_DB migration more robust (Mellanox platform: attach queues 2 and 6 to lossy profile using generic buffer template #2651) (16 hours ago) [Stepan Blyshchak]
c7df6dfa - Fixed a bug in "show vnet routes all" causing screen overrun. (Add hook to allow customizing link cable lengths #2644) (16 hours ago) [siqbal1986]
a5505f02 - show logging CLI support for logs stored in tmpfs (Traceback error seen while issuing show interface commands with if_names #2641) (16 hours ago) [mihirpat1]
bbacb91a - [system-health] Fix issue: show system-health CLI crashes (Updating deb package for platform and sai #2635) (16 hours ago) [Junchao-Mellanox]
8d724024 - [sai_failure_dump]Invoking dump during SAI failure ([dockers]: Upgrade LLDP docker to stretch build #2633) (16 hours ago) [Sudharsan Dhamal Gopalarathnam]
3c3be526 - Add transceiver info CLI support to show output from TRANSCEIVER_INFO for ZR ([submodule]: Update sonic-sairedis pointer #2630) (16 hours ago) [mihirpat1]
37f41666 - [show] add support for gRPC show commands for active-active ([bitmap-vnet]: Bitmap vnet test image [DO NOT MERGE] #2629) (16 hours ago) [vdahiya12]
b06d7fe4 - [show_bfd] add local discriminator in show bfd command ([Pmon] Selectively load pmon container daemons #2625) (16 hours ago) [Baorong Liu]
6adcd3e8 - [GCU] Ignore bgpraw table in GCU operation ([Mellanox] Fix SAI version #2628) (16 hours ago) [jingwenxie]
c65bdc35 - [muxcable][config] Add support to enable/disable ceasing to be an advertisement interface when radv service is stopped (Add knob in ConfigDB to enable/disable telemetry container #2622) (16 hours ago) [Jing Zhang]
91e9457f - Add Transceiver PM basic CLI support to show output from TRANSCEIVER_PM table for ZR ([201803] Restart SwSS, syncd and dependent services if a critical process in syncd container exits #2615) (16 hours ago) [longhuan-cisco]
54cc8c5a - Remove TODO comment which is no longer relevant (Warm-reboot: teamd warm restart caused neighbor deleted and learned again.  #2600) (16 hours ago) [Lior Avramov]
6891b4fb - Making 'show feature autorestart' more resilient to missing auto_restart config in CONFIG_DB ([submodule] update mellanox hw-mgmgt pointer (V.2.0.0061) #2592) (16 hours ago) [kartik-arista]
1e8bea37 - [storyteller] add link prober state change to story teller ([sonic-buildimage] New feature managementVRF(L3mdev) #2585) (16 hours ago) [Jing Zhang]
7481a20f - Extend fast-reboot STATE_DB entry timer ([submodule]: update sonic-swss-common, sonic-py-swsssdk, sonic-snmpagent #2577) (16 hours ago) [Aryeh Feigin]
0e08701c - [sonic_installer] use /etc/resolv.conf from the host when migrating packages (Set a rate limit on syslog messages from all Docker containers #2573) (16 hours ago) [Stepan Blyshchak]
06096780 - Fixed admin state config CLI for Backport interfaces (Prior to install a new ONIE SONiC image, delete all partitions except EFI/ONIE #2557) (16 hours ago) [anamehra]
9f1f13e4 - [show] Add bgpraw to show run all (Fixed typo on paragraph #40 #2537) (16 hours ago) [jingwenxie]
98bc8bd2 - [chassis][voq] Add "show fabric reachability" command. ([ntp]: Build 4.2.6 locally. #2528) (16 hours ago) [jfeng-arista]
3a50b63f - Preserve copp tables through DB migration ([docker-radvd]: upgrade docker radvd to stretch based #2524) (16 hours ago) [Aryeh Feigin]
28f6b127 - [masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links (solve dependency issue #2466) (16 hours ago) [wenyiz2021]
15026e14 - suppport multi asic for show queue counter ([dockers] Prevent old supervisord messages from gettting re-logged to syslog #2439) (16 hours ago) [zhixzhu]
2d773e17 - [masic support] 'show run bgp' support for multi-asic (lo address not synced to the asic #2427) (16 hours ago) [wenyiz2021]
sonic-swss

4f304bc - [EVPN]Handling race condition when remote VNI arrives before tunnel map entry ([sonic-quagga] Function defect, do NOT cancel route while connect IP down #2642) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
34fc615 - [sai_failure_dump]Invoking dump during SAI failure (Add hook to allow customizing link cable lengths #2644) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
b817695 - [autoneg]Fixing adv interface types to be set when AN is disabled (Fix issue with platform file path name #2638) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
ab36bd4 - [bfdorch] add local discriminator to state DB ([bitmap-vnet]: Bitmap vnet test image [DO NOT MERGE] #2629) (15 hours ago) [Baorong Liu]
6343471 - Remove TODO comments that are no longer relevant (Add knob in ConfigDB to enable/disable telemetry container #2622) (15 hours ago) [Lior Avramov]
2b1869c - [refactor]Refactoring sai handle status (Rollback kernel submodule update. #2621) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
c41a1b7 - Fix issue ARP entry is out of sync between kernel and APPL_DB after warm reboot if the ARP entry is updated more than once during warm reboot in PFC watchdog warm reboot test #13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([sub module] advance sonic-utilities sub module for 201811 branch #2619) (15 hours ago) [Stephen Sun]
da0cf7a - Changed the BFD default detect multiplier to 10x ("failed to load plugin io.containerd.snapshotter..." seen during linux boot up #2614) (15 hours ago) [siqbal1986]
13b5adf - [vstest] Only collect stdout of orchagent_restart_check in vstest ([submodules] update swss and utilities pointers #2597) (15 hours ago) [bingwang-ms]
2b9d94d - Avoid aborting orchagent when setting TUNNEL attributes (build failing for PLATFORM=p4 #2591) (15 hours ago) [Stephen Sun]
99b7d3b - Only collect stdout of orchagent_restart_check in vstest ( [saibcm-modules]: import new bcm modules #2578) (15 hours ago) [bingwang-ms]
5209c42 - dereg acl-rule counters during acl-table del ([201803] Set a rate limit on syslog messages from all Docker containers #2574) (15 hours ago) [Vivek]
ae68054 - Fixed set mtu for deleted subintf due to late notification ([vs]: Add option to specify platform name for DVS orchagent #2571) (15 hours ago) [EdenGri]
ab13dfa - Remove TODO comments which are no longer needed (support set timezone in ConfigDB #2568) (15 hours ago) [Junchao-Mellanox]
a3545cf - Modify coppmgr mergeConfig to support preserving copp tables through reboot. (Added new SN3700/SN3700C Mellanox platforms #2548) (15 hours ago) [Aryeh Feigin]
be16e79 - Use github code scanning instead of LGTM ([201803] [services] Restart SwSS service upon unexpected critical process exit #2546) (15 hours ago) [Liu Shilong]
63c0234 - Updated handling of VRF_VNI mapping and VLAN_VNI mapping for same VNI ID (Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… #2538) (15 hours ago) [Tapash Das]
4844111 - Fix potential risks ([mlnx] Fix sai xml path for boxer platform #2516) (15 hours ago) [Liran-Ar]
6420808 - [p4orch]: PINS Extension tables support ([build] When generating image version, handle case where current commit has no reachable tags #2506) (15 hours ago) [svshah-intel]
sonic-swss-common

1badd46 - Increase the netlink buffer size from 3MB to 16MB. (arp_update doesn't sleep 300 between each execution #739) (14 hours ago) [KISHORE KUNAL]
6555057 - Refactor eventpublisher deinit ([acl] Add default deny rule for l3 table #734) (14 hours ago) [Zain Budhwani]
f4d6de7 - Use github code scanning instead of LGTM ([sonic-quagga]:update submodule #718) (14 hours ago) [Liu Shilong]
sonic-linux-kernel

74f9a8f - Update linux kernel for hw-mgmt V.7.0020.4104 (Move template files to /usr/share/sonic/templates #305) (14 hours ago) [Stephen Sun]
6365701 - Fixes for emmc unreliability ([build_debian.sh]: Integrate system dump script #270) (14 hours ago) [Samuel Angebault]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannankvs kannankvs kannankvs left review comments

@nikos-github nikos-github nikos-github requested changes

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vharish02 @lguohan @batmancn @kannankvs @pavel-shirshov @nikos-github @jleveque