Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libteam]: Fixing the port add issue #3725

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Nov 7, 2019

- What I did
Fixed a bug #3725 . Which caused following log output. The bug was observed, because team_refresh() expect to see the port enabled, but the port is being enabled later by team_set_port_enabled().

Ethernet50: Failed to find "enabled" option.
get_ifinfo_list: check_call_change_handers failed
Failed to get interface information list.
Failed to refresh interface information list.
Ethernet50: Team refresh failed.
    /* refresh ports from the kernel */
    err = team_refresh(ctx->th);
    if (err) {
        teamd_log_err("%s: Team refresh failed.", tdport->ifname);
        goto timeout_callback_del;
    }

    /* Newly added ports are disabled */
    err = team_set_port_enabled(ctx->th, tdport->ifindex, false);
    if (err) {
        teamd_log_err("%s: Failed to disable port.", tdport->ifname);
        if (!TEAMD_ENOENT(err))
            goto timeout_callback_del;
    }

- How I did it
I run team_set_port_enabled() function before the team_refresh() function

- How to verify it
Build libteam and run on the switch

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Nov 8, 2019

do we need this for 201811 branch?

@pavel-shirshov
Copy link
Contributor Author

Yes @lguohan if it fixes the issue.
I still can't reproduce it on my dut

@stepanblyschak
Copy link
Collaborator

@pavel-shirshov @lguohan Still observe the issue after 2 iterations of warm reboot with this PR, on 201811 can't reproduce.

@pavel-shirshov
Copy link
Contributor Author

@stepanblyschak Can you please share logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants