libyang python APIs #3874
Closed
libyang python APIs #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Package will contain YANG models for sonic which are written with guidelines mentioned in https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md. This package will include python yang libraries which will be used with sonic utilities pacakge to validate the config.
- python APIs based on libyang
- functions to load/merge yang models and data files
- add/set/delete node in schema and data trees
- find dependencies
| }, | ||
| author="lnos-coders", | ||
| author_email='lnos-coders@linkedin.com', | ||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', |
There was a problem hiding this comment.
Same comment as before. Can we switch to >= 3.5
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-acl.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-acl.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-head.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-interface.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-module.yang
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-port.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-portchannel.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-vlan.yang
Outdated
Show resolved
Hide resolved
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-acl.yang
Outdated
Show resolved
Hide resolved
| return mod | ||
|
|
||
| """ | ||
| load_data_model(): load both Yang module fileis and data json files |
| if (module is not None): | ||
| if (format == "XML"): | ||
| #libyang bug with format | ||
| result = module.print_mem(ly.LYD_JSON, ly.LYP_FORMAT) |
There was a problem hiding this comment.
So you ask for LYD_JSON for XML & LYD_XML for JSON ?
Apparently this bug does not impact self.root
There was a problem hiding this comment.
A bug in libyang
li-pingmao
referenced
this pull request
in li-pingmao/sonic-buildimage
Mar 22, 2020
praveen-li
referenced
this pull request
in zhenggen-xu/sonic-buildimage
May 1, 2020
|
@li-pingmao : Kindly close this PR, by giving reference to PR 3861. Thx |
|
This PR was pushed as part of PR 3861. |
praveen-li
referenced
this pull request
in praveen-li/sonic-buildimage
May 8, 2020
Changes: 1.) prefix test_ for sample yang models. 2.) name properly with data_node or schema_node. 3.) Update function calls after libyang PLY APIs updates. 4.) Fix test cases after sample yang files name changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
libyang Python APIs:
- python APIs based on libyang
- functions to load/merge yang models and Yang data files
- function to validate data trees based on Yang models
- functions to merge yang data files/trees
- add/set/delete node in schema and data trees
- find data/schema nodes from xpath from the Yang data/schema tree in memory
- find dependencies
- dump the data tree in json/xml
- How I did it
- based on libyang python2 modules which is built by libyang
- add functions to load/validate Yang models and Yang data trees
- Add functions to
- How to verify it
- pytests while build sonic-yang-mgmt python wheel package
- create sample Yang models for sonic ACL/interface/port/clan
- sample Yang data files
- test file with test cases, it includes categories to test, xpath and expected results for testing Yang data/schema tree wrapper functions
pytests while build target/python-wheels/sonic_yang_mgmt-1.0-py2-none-any.whl:
============================= test session starts ==============================
platform linux2 -- Python 2.7.13, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /sonic/src/sonic-yang-mgmt, inifile:
plugins: cov-2.4.0
collected 18 items
tests/test_sonic_yang_mgmt.py .
tests/libyang-python-tests/test_sonic_yang.py .................
========================== 18 passed in 0.21 seconds ===========================
- Description for the changelog
Note: Due to dependency on PR#3861 (#3861), this PR has 2 commits, please review the 2nd commit only(the first commit in this PR is a cherry-pick of PR#3861).
- A picture of a cute animal (not mandatory but encouraged)