[docker-frr] Load frr.conf automatically with split mode #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
|
@zhenggen-xu Where can I read the difference between: "split", "separated", and "unified"? |
I am not sure where the document is. My understanding is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docker-frr] Load frr.conf automatically with split mode
Signed-off-by: Zhenggen Xu zxu@linkedin.com
This should be back-ported to 201911 branch.
- What I did
In case "docker_routing_config_mode": "split", the frr.conf was not loaded automatically today.
This PR is to fix that so it would load the frr.conf automatically
- How I did it
start.sh in docker frr to load the frr.conf automatically
- How to verify it
Before the fix, not frr.conf was loaded. After the fix, frr.conf was loaded.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)