Add fabric lane mapping to vs Force10-S6000 sai.profile #6185
Conversation
Signed-off-by: ngocdo <ngocdo@arista.com>
|
Please don't merge it yet. Let's wait until sonic-net/sonic-swss#1431 merges. |
|
retest vs please |
Now voq and fabric asics are enabled with fabric ports. Need to fix the tests to count for fabric ports. vstest infrastructure for fabric ports merged in sonic-net/sonic-sairedis#737 and 769. This infrastructure requires sonic-net/sonic-buildimage#6185 to be effective. However, this PR (6185) will have some swss tests failing. We need to disable those tests, let the PR merge, and reenable the tests.
|
retest vs please |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Now voq and fabric asics are enabled with fabric ports. Need to fix the tests to count for fabric ports. vstest infrastructure for fabric ports merged in sonic-net/sonic-sairedis#737 and 769. This infrastructure requires sonic-net/sonic-buildimage#6185 to be effective. However, this PR (6185) will have some swss tests failing. We need to disable those tests, let the PR merge, and reenable the tests.
|
@daall Hello Danny. I'm not sure if you should merge this one now. Like I mentioned in one comment in sonic-net/sonic-swss#1459, if we merge this PR now, some swss tests will fail. The steps are merge sonic-net/sonic-swss#1459, and then this one, and then fix 1459 by enabling fabric port tests. We didn't see test failures, since I think we didn't run swss tests here? |
Per the discussion in this PR I thought this PR only depended on 1431 and 1459 depended on this PR. If we need 1459 to merge first then I will open a revert PR for this PR. |
Yes, please revert it. What happens then when we want to merge this PR. Do I need to create a new one? |
Yep, just create a new PR with the same contents of this PR and then we can merge it once all the dependencies are ready! :) |
👍 Sure thanks. |
Now voq and fabric asics are enabled with fabric ports. Need to fix the tests to count for fabric ports. vstest infrastructure for fabric ports merged in sonic-net/sonic-sairedis#737 and 769. This infrastructure requires sonic-net/sonic-buildimage#6185 to be effective. However, this PR (6185) will have some swss tests failing. We need to disable those tests, let the PR merge, and reenable the tests.
…onic-net#6185) Signed-off-by: ngocdo <ngocdo@arista.com>
…-S6000 (sonic-net#6185)" (sonic-net#7250) This reverts commit c2b5e93.
…7629) This PR is actually #6185 that was merged and then reverted to avoid test failure in swss. Now sonic-net/sonic-swss#1459 merged, and so this PR could merge to enable fabric test in swss. Signed-off-by: ngocdo <ngocdo@arista.com>
…onic-net#6185) Signed-off-by: ngocdo <ngocdo@arista.com>
…-S6000 (sonic-net#6185)" (sonic-net#7250) This reverts commit c2b5e93.
…onic-net#7629) This PR is actually sonic-net#6185 that was merged and then reverted to avoid test failure in swss. Now sonic-net/sonic-swss#1459 merged, and so this PR could merge to enable fabric test in swss. Signed-off-by: ngocdo <ngocdo@arista.com>
Signed-off-by: ngocdo ngocdo@arista.com
- Why I did it
This PR will add fabric lane mapping for vs tests. The fabric lane mapping will be used by vslib similarly it is doing with front panel lane mapping.
The lane mapping has lane for 16 fabric ports. Each port has one lane.
This PR is part of fabric support on Sonic, together with sonic-net/sonic-swss#1459.