Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the whole SONiC to be built with SONIC_DEBUGGING_ON=y. #6299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Str1ker17
Copy link

@Str1ker17 Str1ker17 commented Dec 25, 2020

Signed-off-by: Alexey Suslov alexey.s+git@ultibot.ru

- Why I did it
I wanted test & developement builds of SONiC to contain all the debug info. However if I build SONiC with SONIC_DEBUGGING_ON=y, the build stops as not all dbgsym packages are generated.

- How I did it
Replaced absent dbgsym packages with a dummy .deb file.

- How to verify it
Open rules/config in text editor and uncomment SONIC_DEBUGGING_ON=y.
Then build as usual:

make configure PLATFORM=broadcom
make target/sonic-broadcom.bin

The reulting image is somewhat bigger, but not much.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

Enabled the whole SONiC image to be built with debug info.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Alexey Suslov <alexey.s+git@ultibot.ru>
@ghost
Copy link

ghost commented Dec 25, 2020

CLA assistant check
All CLA requirements met.

@lguohan lguohan added the Build label Dec 25, 2020
@lguohan
Copy link
Collaborator

lguohan commented Dec 25, 2020

can you check this pr? seems trying to solve the same issue? #6058

@Str1ker17
Copy link
Author

Yes, it seems the issue is the same.
However we are both doing the wrong way; the right way is to make debhelper generate an empty dbgsym.deb file.
@tim-rj what do you think about it?

@tim-rj
Copy link
Contributor

tim-rj commented Dec 29, 2020

hi Str1ker17, I think since there are no dbgsym debs when option is nostrip, there is no need to touch empty dbgsym debs just for compiling.

@Str1ker17
Copy link
Author

@tim-rj But I want the full SONiC image containing all possible debug symbols. Why it is not possible to build it out of the box?
If some package is poorly configured and does not export symbols from itself, I see few reasons to break the build completely in this case.

P.S. I am responding after a year, so the situation has possibly changed. So please tell me if it's possible to build SONiC with all debug symbols.

@raphaelt-nvidia
Copy link
Contributor

@tim-rj But I want the full SONiC image containing all possible debug symbols. Why it is not possible to build it out of the box? If some package is poorly configured and does not export symbols from itself, I see few reasons to break the build completely in this case.

P.S. I am responding after a year, so the situation has possibly changed. So please tell me if it's possible to build SONiC with all debug symbols.

It hasn't changed. The problems described in #6413 andhttps://github.com//issues/5982 still exist.

@Str1ker17 Str1ker17 requested review from a team as code owners June 10, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants